#1913 - v10 Donation Banner

This is a spacer post for a website comment topic. The content this topic relates to: #1913 - v10 Donation Banner
Also opens the link in a new tab, which probably makes sense for an external url but not for the donation banner.
A few points:
- Couldn't reproduce main error, but fixed issue in API
- Fixed issues on dev mode that happened when I tested
- Made local URLs not open in new window
- Weird placing of banner can happen now if an error happens mid-rendering of a page. This is due to the output streaming option (sends output as soon as page rendering starts, a big optimisation).
- It will say missing page when you click these default banners, but if you go to add it will use a matching page template to bring in a default version of the page. This is intentional to reduce bloat, I never liked us having these hard-coded 'donate' and 'advertise' pages that came with the banners addon, far too big an assumption (deleting the default banners is still necessary, but that's far less intrusive than default pages).
Okay, that all makes sense and glad you fixed it up some.
There is actually a typo at the start of the banner itself, 'maintaing'
Fixed
1 guest and 0 members have recently viewed this.