#1913 - v10 Donation Banner
-
By Adam Edington
- Added
- 16 views
| Identifier | #1913 |
|---|---|
| Issue type | Major issue (breaks an entire feature) |
| Title | v10 Donation Banner |
| Status | Completed |
| Handling member | Chris Graham |
| Addon | General / Uncategorised |
| Description | Clicking on the Donate banner (which appears in a weird place on certain pages and not at all on others) gives the following white screen error.
Notice: Undefined index: FORUM_DRIVER in C:\Program Files (x86)\EasyPHP-DevServer-14.1VC9\data\localweb\demos\composr\sources\database.php on line 475 Fatal error: Call to a member function get_drivered_table_prefix() on a non-object in C:\Program Files (x86)\EasyPHP-DevServer-14.1VC9\data\localweb\demos\composr\sources\database.php on line 475 |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
- Couldn't reproduce main error, but fixed issue in API
- Fixed issues on dev mode that happened when I tested
- Made local URLs not open in new window
- Weird placing of banner can happen now if an error happens mid-rendering of a page. This is due to the output streaming option (sends output as soon as page rendering starts, a big optimisation).
- It will say missing page when you click these default banners, but if you go to add it will use a matching page template to bring in a default version of the page. This is intentional to reduce bloat, I never liked us having these hard-coded 'donate' and 'advertise' pages that came with the banners addon, far too big an assumption (deleting the default banners is still necessary, but that's far less intrusive than default pages).