View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 651 | Composr non-bundled addons | General / Uncategorised | public | 2012-07-02 12:52 | 2024-08-04 22:17 |
| Reporter | Chris Graham | Assigned To | Guest | ||
| Priority | normal | Severity | feature | ||
| Status | new | Resolution | open | ||
| Summary | 651: Sync with upstream libraries (dependencies) and with API versions (ongoing) | ||||
| Description | We use a number of large packages in Composr addons (including some bundled ones). These need to be maintained. For example we may get code quality validation issues (e.g. use of 'ereg') in them that could cause issues for people, or there may simply be bugs we need fixed. Maintain a spreadsheet of our policy with each project and the sync status. Regularly update that status, and re-sync, as appropriate. This is all very much a case-by-case basis. Some packages are maintained well, and we just need to resync them cleanly. Some packages are unmaintained, and thus we maintain our own heavy forks of them. Or in some cases we may take up maintenance with our own separate fork gitlab repository. And in some cases we may be active contributors to the project. The list is in Git, as data_custom/third_party_code.csv. There are also new APIs that we need to track. For example, a new version might be out, and we should shift before old versions are no longer supported. The list is in Git, as data_custom/third_party_apis.csv. There is an automated test that helps us with both spreadsheets. For example, if we have not updated the status of a package/API in a year, it asks us to review and update it. | ||||
| Additional Information | Also see the "Properly index 3rd-party code" coding standard we have documented. A lot of things have to be properly updated when integrating third party library code. | ||||
| Tags | Roadmap: ongoing, Roadmap: Over the horizon, Type: External dependency | ||||
| Attach Tags | |||||
| Time estimation (hours) | 40 | ||||
| Sponsorship open | |||||
| related to | 2578 | Resolved | Chris Graham | Composr | Official non-maintained status |
| related to | 3671 | Resolved | Chris Graham | Composr | Cookie Consent Update |
| has duplicate | 5367 | Resolved | Guest | Composr alpha bug reports | WebDAV PHP 8.1 deprecation for ctype_digit |
| related to | 3294 | Resolved | Chris Graham | Composr non-bundled addons | Facebook SDK needs replacing |
| related to | 3338 | Resolved | Chris Graham | Composr | Health Checks for all APIs |
| related to | 2403 | Not Assigned | Guest | Composr | Track new software releases (ongoing) |
|
|
This was mostly completed for v11 earlier in the year, and I just finished redoing the Facebook as part of Hybridauth integration. I have retagged for v12 as we will need to revisit this regularly. |
|
|
We won't have time to re-do this for the final v11 release, and the third_party_code test (testSyncDates specificaly) is failing on them needing review again. For now I put in a 3 year time between reviews so our continuous integration doesn't break down, but this needs reducing back to 1 year. |
|
|
Historically we have been bad at contributing to upstream projects. We should rectify this and maintain forks as little as possible. |
|
|
I prefer the plugin route as per my latest updates to MantisBT. Whenever possible, make a Composr plugin for the project to handle all the integrations instead of overwriting the projects' original code and having to maintain it. There will be a couple of exceptions. For example, MantisBT still doesn't have full compatibility with our needs, so a few files still needed overwriting. And their sponsorship block (widget) is a disaster UI-wise, so I re-did it to conform to the layout of their other blocks (widgets). |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-08-03 12:32 | Chris Graham | Description Updated | |
| 2016-08-03 12:32 | Chris Graham | Additional Information Updated | |
| 2016-08-03 12:35 | Chris Graham | Description Updated | |
| 2016-10-05 23:25 | Chris Graham | Relationship added | related to 2578 |
| 2016-12-12 10:04 | Chris Graham | Description Updated | |
| 2016-12-12 10:05 | Chris Graham | Additional Information Updated | |
| 2017-04-26 22:25 | Chris Graham | Description Updated | |
| 2017-07-09 14:01 | Chris Graham | Description Updated | |
| 2017-07-09 14:01 | Chris Graham | Additional Information Updated | |
| 2017-07-09 14:11 | Chris Graham | Additional Information Updated | |
| 2018-02-07 21:14 | Chris Graham | Relationship added | related to 3294 |
| 2018-03-07 00:45 | Chris Graham | Additional Information Updated | |
| 2018-03-07 00:46 | Chris Graham | Additional Information Updated | |
| 2018-08-31 17:02 | Chris Graham | Relationship added | related to 3671 |
| 2019-06-27 19:04 | Chris Graham | Tag Attached: Roadmap: v11 | |
| 2019-06-27 19:04 | Chris Graham | Tag Attached: Roadmap: ongoing | |
| 2019-06-27 19:04 | Chris Graham | Tag Attached: Type: External dependency | |
| 2020-02-09 21:26 | Chris Graham | Relationship added | related to 3338 |
| 2020-02-20 02:12 | Chris Graham | Tag Detached: Roadmap: v11 | |
| 2020-02-20 02:12 | Chris Graham | Tag Attached: Roadmap: v11 final phase | |
| 2020-03-07 21:19 | Chris Graham | Assigned To | => Chris Graham |
| 2020-03-07 21:19 | Chris Graham | Status | Not Assigned => Assigned |
| 2020-04-12 03:28 | Chris Graham | Summary | Sync with upstream => Sync with upstream libraries and with API versions (ongoing) |
| 2020-04-12 03:28 | Chris Graham | Description Updated | |
| 2020-04-12 03:28 | Chris Graham | Additional Information Updated | |
| 2020-09-07 18:31 | Chris Graham | Tag Detached: Roadmap: v11 final phase | |
| 2020-09-07 18:31 | Chris Graham | Tag Attached: Roadmap: v12 | |
| 2020-09-07 18:33 | Chris Graham | Note Added: 0006693 | |
| 2022-08-15 15:09 | Chris Graham | Summary | Sync with upstream libraries and with API versions (ongoing) => Sync with upstream libraries (dependencies) and with API versions (ongoing) |
| 2022-08-15 15:09 | Chris Graham | Relationship added | related to 2403 |
| 2022-08-15 15:49 | Chris Graham | Tag Attached: Roadmap: v11 | |
| 2022-08-15 20:45 | Chris Graham | Assigned To | Chris Graham => user4172 |
| 2022-11-20 02:57 | Chris Graham | Tag Detached: Roadmap: v11 | |
| 2022-11-20 03:05 | Chris Graham | Assigned To | user4172 => |
| 2022-11-20 03:05 | Chris Graham | Status | Assigned => Not Assigned |
| 2023-01-02 23:19 | Chris Graham | Note Added: 0007859 | |
| 2023-02-26 02:09 | Chris Graham | Relationship added | has duplicate 5367 |
| 2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |
| 2024-03-26 00:58 | PDStig | Tag Renamed | Roadmap: v12 => Roadmap: Over the horizon |
| 2024-08-04 20:19 | Chris Graham | Note Added: 0009075 | |
| 2024-08-04 22:17 | PDStig | Note Added: 0009085 |
