View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
3671Composrcore_addon_managementpublic2018-08-30 04:162020-03-29 18:28
ReporterAdam Edington Assigned ToChris Graham  
PrioritynormalSeverity@40@ 
Status resolvedResolutionfixed 
Summary3671: Cookie Consent Update
DescriptionThe Cookie Consent JS script we use has been revised.

I seem to have it working fine with the following code.

{$,Cookie Consent plugin by Silktide - http://silktide.com/cookieconsent}
{+START,IF,{$AND,{$CONFIG_OPTION,cookie_notice},{$RUNNING_SCRIPT,index}}}
    <link rel="stylesheet" type="text/css" href="//cdnjs.cloudflare.com/ajax/libs/cookieconsent2/3.1.0/cookieconsent.min.css" />
    <script src="//cdnjs.cloudflare.com/ajax/libs/cookieconsent2/3.1.0/cookieconsent.min.js"></script>
    <script>
    window.addEventListener("load", function(){window.cookieconsent.initialise({"palette": {"popup": {"background": "#000"},"button": {"background": "#FFF"}},"theme": "block","position": "top","static": true,"content": {"message": "{!COOKIE_NOTICE;/,{$SITE_NAME}}","dismiss": "{!INPUTSYSTEM_OK;}","link": "{!READ_MORE;}","href": "{$PAGE_LINK;/,:privacy}"}})});
    </script>
{+END}

Some new options in the new version to only show the notice in countries which require it (which might tie in with Composr regionalisation somehow and allow this to default to being active).
TagsRoadmap: v11, Type: External dependency
Attach Tags
Time estimation (hours)0.5
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Relationships

Search Commits
related to 651 Not AssignedGuest Composr non-bundled addons Sync with upstream libraries (dependencies) and with API versions (ongoing) 

Activities

Salman

2019-07-12 19:26

reporter   ~6034

Implemented by [1] but no country detection is being done. Looking into that.

1: https://github.com/ocproducts/composr/commit/873da9e13631d8b4a34f70eb42efc38dc74c14d3

Chris Graham

2019-07-12 19:33

administrator   ~6035

If they do this via IP detection, we can just let that run.
If they require an ISO code to be passed, we can detect that using our get_country() function (which uses a combination of methods, ultimately IP_Country.txt).

Discuss with me in IRC if you like.

Adam Edington

2019-07-12 20:08

administrator   ~6036

Last edited: 2019-07-12 21:15

 3.1.1 is the latest release and the credit is now Osano, not Silktide
https://cookieconsent.osano.com/

This is the location demo @ https://cookieconsent.osano.com/examples/example-6-location.html

Salman

2019-07-12 20:45

reporter   ~6037

Country detection implemented using get_country() and notice enabled by default [1]. Cookie Consent has support for location detection services but that requires fiddling around with API keys and paying for them or dealing with per day call limits.

Thanks for the heads up @Adam, updated.

1: https://github.com/ocproducts/composr/commit/05f21166b13a14eadd1fe3d3df8a4e6eaa2f06a2

Adam Edington

2019-07-27 21:40

administrator   ~6043

Last edited: 2019-07-27 21:46

 https://cdn.jsdelivr.net/npm/cookieconsent@3/build/cookieconsent.min.css
https://cdn.jsdelivr.net/npm/cookieconsent@3/build/cookieconsent.min.js

Might be a better CDN to use as it always links to the latest version.

<script src="https://cdn.jsdelivr.net/npm/cookieconsent@3/build/cookieconsent.min.js" data-cfasync="false"> is the example, not sure how important the data-cfasync is but thought I would mention that too.

Chris Graham

2019-07-28 23:19

administrator   ~6045

We possibly should not be using any CDN.

I have just added a new coding standard which I think is important:

"Unless intrinsically necessary for a particular piece of functionality, do not rely on external URLs such as CDNs. External URLs create a number of problems, including: network firewalls operating with whitelists blocking functionality (e.g. in museums), erratic firewall blocking (e.g. in China), full functionality not being available offline (e.g. when developing on an airplane), or full functionality not working in private offline Intranets (e.g. in schools). If users want to make use of CDNs they can make manual changes to achieve it."

It might be we need to remote link, but I doubt it.

I realise v10 is remote linking, so this is a change.

Adam Edington

2019-07-29 15:27

administrator   ~6049

I agree that all files should be available locally. Something like fallback.js ( http://fallback.io/ ) might be useful if any CDN fails for whatever reason, because there are some benefits to CDN's.

Issue History

Date Modified Username Field Change
2018-08-30 04:16 Adam Edington New Issue
2018-08-30 04:19 Adam Edington Sponsorship open 0 =>
2018-08-30 04:19 Adam Edington Description Updated
2018-08-31 17:02 Chris Graham Relationship added related to 651
2018-08-31 17:03 Chris Graham Time estimation (hours) => 0.5
2018-08-31 17:03 Chris Graham Description Updated
2019-06-27 17:51 Chris Graham Tag Attached: Roadmap: v11
2019-06-27 17:51 Chris Graham Tag Attached: Type: External dependency
2019-07-01 19:27 Chris Graham Assigned To => user4127
2019-07-01 19:27 Chris Graham Status Not Assigned => Assigned
2019-07-12 19:26 Salman Note Added: 0006034
2019-07-12 19:33 Chris Graham Note Added: 0006035
2019-07-12 20:08 Adam Edington Note Added: 0006036
2019-07-12 20:24 Adam Edington Note Edited: 0006036
2019-07-12 20:45 Salman Status Assigned => Resolved
2019-07-12 20:45 Salman Resolution open => fixed
2019-07-12 20:45 Salman Note Added: 0006037
2019-07-12 21:15 Adam Edington Note Edited: 0006036
2019-07-27 21:40 Adam Edington Note Added: 0006043
2019-07-27 21:46 Adam Edington Note Edited: 0006043
2019-07-28 23:16 Chris Graham Status Resolved => Assigned
2019-07-28 23:19 Chris Graham Note Added: 0006045
2019-07-29 15:27 Adam Edington Note Added: 0006049
2020-03-28 01:06 Chris Graham Assigned To user4127 => user4172
2020-03-29 16:11 Chris Graham Assigned To user4172 => Chris Graham
2020-03-29 18:28 Chris Graham Status Assigned => Resolved