View Issue Details

IDProjectCategoryView StatusLast Update
5608Composr non-bundled addonsGeneral / Uncategorisedpublic2024-07-25 19:17
ReporterPDStig Assigned ToPDStig  
PrioritynormalSeverityfeature 
Status resolvedResolutionfixed 
Summary5608: Refactor make_release into a proper module admin_make_release (+ additional changes as indicated)
DescriptionConvert the make_release minimodule to an admin_make_release module using language strings instead of hard-coded language text.

Use the form template API instead of echoing out everything raw.

Also, add in the ability to modify the URLs used during the make_release process (will be necessary for the early stages of v11).
Additional InformationThe primary reasons why I decided to convert this to a regular module and use language strings are as follows:

1. Better code readability / structure as it is a pretty large module.
2. Support for more than just English.
3. Support for de-branding by using "the software" instead of "Composr".
4. Support for customizing individual steps via translate / rephrase as appropriate.

For the time being, all other minimodules for the build addon will be left as minimodules as they either have no sufficient UI or are small in functionality.

This will NOT be ported to v10; this will only be for v11.
TagsRoadmap: v11
Attach Tags
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Relationships

related to 5609 AssignedPDStig Composr build tools Add unit test for composr_release_build.ini to check target="_blank" 

Activities

Chris Graham

2024-07-25 19:11

administrator   ~8940

I'm dubious about reasons 2-4. I don't see why we would be paying the costs associated with other teams trying to fork Composr. However, if '1' was important, fair enough.

PDStig

2024-07-25 19:17

administrator   ~8942

It was already done; it worked out for the better because it enabled easier use of specifying custom URLs for the APIs to hit as well as updating the version file.

Issue History

Date Modified Username Field Change
2024-02-12 00:50 PDStig New Issue
2024-02-12 00:50 PDStig Status Not Assigned => Assigned
2024-02-12 00:50 PDStig Assigned To => user4172
2024-02-12 00:50 PDStig Tag Attached: Roadmap: v11
2024-02-12 00:50 PDStig Additional Information Updated
2024-02-12 03:31 PDStig Status Assigned => Resolved
2024-02-12 03:31 PDStig Resolution open => fixed
2024-02-12 03:33 PDStig Relationship added related to 5609
2024-07-25 19:11 Chris Graham Note Added: 0008940
2024-07-25 19:17 PDStig Note Added: 0008942