View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
1753Composrcore_themeingpublic2015-01-11 14:532016-03-28 14:04
ReporterChris Graham Assigned ToChris Graham  
PrioritynormalSeverityfeature 
Status resolvedResolutionfixed 
Summary1753: Improved cross-file editing
Description1) Record meta-data tree

Have a new filesystem directory, themes/_meta_tree

The tree serves two purposes:
1) For convenient editing outside Composr (quickly finding related templates etc, double click to open files directly in text editor)
2) For storing relationships inside Composr, so we can show the navigation tree in the new themeing editor

This directory would be automatically constructed, and consist of a structure of directories and symlinks.

themes
 <theme name>
  _meta_tree
   screens
    <page-link>
     <template name> (template tree encoded via directory tree, each tree node is a directory)
      {_self --> <template file for directory>}
      _meta.txt (contains details of the node: for each time this template is a child of its parents what parameter name is it being inserted via and what GUID was used)
   templates
    _all
     {<template name> --> <template file>}
    <addon name>
     {<template name> --> <template file>}
   css
    _all
     {<template name> --> <template file>}
    <addon name>
     {<template name> --> <template file>}
   javascript
    _all
     {<template name> --> <template file>}
    <addon name>
     {<template name> --> <template file>}
   xml
    _all
     {<template name> --> <template file>}
    <addon name>
     {<template name> --> <template file>}
   text
    _all
     {<template name> --> <template file>}
    <addon name>
     {<template name> --> <template file>}
   templates-related
    _all
     <template name>
      {<template name> --> <template file>}
    <addon name>
     <template name>
      {<template name> --> <template file>}
   css-related
    _all
     <template name>
      {<template name> --> <template file>}
    <addon name>
     <template name>
      {<template name> --> <template file>}
   javascript-related
    _all
     <template name>
      {<template name> --> <template file>}
    <addon name>
     <template name>
      {<template name> --> <template file>}
   xml-related
    _all
     <template name>
      {<template name> --> <template file>}
     <addon name>
     <template name>
     {<template name> --> <template file>}
   text-related
    _all
     <template name>
      {<template name> --> <template file>}
    <addon name>
     <template name>
      {<template name> --> <template file>}

"<...>" denotes some variable property.
"{...} --> ..." denotes a symlink.

In summary the tree is recording a few things not easy to find in the current Composr:
1) Related templates (co-reference, e.g. FORM.tpl is seen on the same screens as FORM_SCREEN_INPUT_INTEGER.tpl)
2) Templates organised by addon
3) Direct symlinks to template files without worrying about where/if things are overridden
4) Permanently stored template trees on a per-screen basis
5) Extended contextual meta data the current template tree system doesn't show you

The tree would need to be automatically maintained with correct symlinks when anything was overridden.

The tree would 'grow' at run-time, as it picks up meta-data. However, only if an "Grow template meta tree" option was enabled or keep_grow_template_meta_tree=1 is set or special_page_type=edit_html_and_css is set. This option defaults to on and is filed under performance options.

In some cases 'templates' in the tree are actually Comcode pages.

2) Change page rendering tools

Remove the following page rendering tool links:
 - Templates
 - Template tree
 - Contextual CSS edit: *
and replace them with an "Edit HTML and CSS" link

Remove all the code relating to the templates/template tree view modes.

As per the current "Contextual CSS edit", choosing "Edit HTML and CSS" will establish a preview-anchor.
It will also refresh the main page with special_page_type=edit_html_and_css before opening the child window (in fact, special_page_type=edit_html_and_css adds some special JavaScript code to open the child window, as otherwise we couldn't broker that through a refresh-operation).

The child window would be opened with knowledge of the page-link it is for. This will open the new themeing editor expanded to show opening links for screens\<page-link>

3) New themeing editor

Merge the CSS and Template editor code, and add support for page editing too.
Rip out editarea and add Ace Editor instead (contingent on this being implemented separately); page editing would still use CKEditor. The correct editor would be openable on a per-tab basis (i.e. you can have different files in different tabs).

Do a major revamp of the editing UI. Use jquery-ui for it.

Down the left would be a selection tree based on '1' above.
Hovering the mouse over a tree node would show info from _meta.txt, and also the current override status for the file, plus some other meta data (who last edited it, and when, and what the file size is, and what addon it belongs to).
Clicking on a selection tree node would open a new editing tab (using AJAX).

On the right would be the editing tabs.

You could continue to restore old versions of files, but these would load via AJAX rather than a page-refresh.
The "Original" version of the file would be removed, as this could be incorporated into the old versions of files UI (we already have tooltip-based display of file differences).

The toolbar for template editing help would continue to exist.
We would enhance the "insert parameter" UI by auto-scanning screen previews to find what parameters are used by the template (I think we currently can only auto-fill this by scanning the template file, which may not include all possible parameters; although this should still exist as a fallback if there is no screen preview available).

The list of GUIDs would continue to exist.

The help/advice bar would be removed, and instead this information would be incorporated into the main front page for admin_themes.
We may want to add some links into HTML tag references guides, and CSS references guides, on a per-editing-tab basis.

Saving would be done on an individual-tab basis. It would always be save and stay, there'd no longer be a 'save' button that navigates away. Save and stay would be reimplemented using AJAX. If people want to manipulate individual files without browser JavaScript support, they can use /code_editor.php -- put out an accessibility message about this.
Tabs would have to indicate with a '*' if they contain unsaved code. Navigating away would present a window.confirm, checking that you are okay with losing unsaved changes (only if there are unsaved changes though).

4) Previewing

There'd be a list of different ways to preview. Each screen preview a template is used in, and each page-link it is recorded used in, would be offered up as a preview option. The default would be what the addon_registry hooks recommend for the template -- or, if a preview-anchor exists, the page-link from that preview-anchor.

The explicit viewing of a preview would open in a preview window (a third window), NOT the preview-anchor window, regardless of the page-link for the preview-anchor is being previewed.

5) Live highlighting

The CSS editing tabs would inherit the existing live highlight code for selectors, and the live preview code for CSS changes.

The template editing would not have live preview, but hovering over the selection tree would result in highlighting of any HTML DOM nodes directly under the template being edited. This might work with a glow effect.

To establish the relationship between HTML output, and the templates, a special encoding scheme has been devised. We will use invisible unicode characters to wrap around the start and end of each template. Specifically this will work via a binary encoding scheme around the x200b and xfeff characters. We will put <template name>...</template name> around each template but encoded using the special invisible encoding scheme, so that the user doesn't actually see it, only our code does. The invisible markers will show if special_page_type=edit_html_and_css is set.

6) Template/CSS selection list

The list of choosing what template/CSS to edit, before getting to the template/CSS editors, would probably be removed. We would probably jump right into the editor.
TagsNo tags attached.
Attach Tags
Attached Files
Time estimation (hours)16
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Relationships

Search Commits
related to 1562 ResolvedChris Graham Replace EditArea with Ace Editor 
related to 2348 Not AssignedGuest Better template editor tab management 
child of 3362 ResolvedChris Graham Themeing improvements in v11 (idea staging issue) 

Activities

Chris Graham

2015-02-02 12:10

administrator   ~2506

I am very excited about implementing this. Thank you for the sponsorship :).

Practically though, I don't think we can do this as sponsored on v9 (too large a change, and contingent on various things already done for v10), and maybe not v10 (I don't want to delay v10 any further if possible). I am thinking doing it within a 10.1 release.

Rishi Saravanan

2015-02-02 20:06

reporter   ~2516

I could see this would be an important step in the ongoing process of simplifying website editing for admins who are not trained in coding (me:)), so definitely want to help these steps move forward.

I understand. Sounds good to wait for 10.1

Chris Graham

2015-02-10 15:24

administrator   ~2554

We make want to also support .less files within the editor, if the new less addon is installed.

Chris Graham

2015-10-03 11:01

administrator   ~3121

Hello,

I just wanted to drop a quick acknowledgement of how long this has been sitting around. Of course it's because v10 has been taking a long time, and this is set for 10.1.

I very much appreciate the sponsorship and I still very much look forward to implementing this. It's not forgotten (along with related editing issues).

Best,
Chris

Rishi Saravanan

2015-10-03 18:06

reporter   ~3124

yes, looking forward :)

Chris Graham

2016-03-11 23:14

administrator   ~3433

All of part '1' is now implemented.

Here's a sample on-disk meta-tree for the default home page...

./screens/root
./screens/root/start
./screens/root/start/GLOBAL_HTML_WRAP.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/ajax.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/ajax.js/_self.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/ajax_people_lists.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/ajax_people_lists.js/_self.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_NOTIFICATIONS.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_NOTIFICATIONS.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_NOTIFICATIONS.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINE.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINE.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINE.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINE_COMPLEX.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINE_COMPLEX.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINE_COMPLEX.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINE_COMPLEX.tpl/HYPERLINK.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINE_COMPLEX.tpl/HYPERLINK.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINE_COMPLEX.tpl/HYPERLINK.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINK.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINK.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LINK.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LOGOUT.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LOGOUT.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_PERSONAL_STATS.tpl/BLOCK_SIDE_PERSONAL_STATS_LOGOUT.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_SEARCH.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_SEARCH.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/BLOCK_TOP_SEARCH.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/button_commandr.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/button_commandr.js/_self.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_MAIN_COMCODE_PAGE_CHILDREN.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_MAIN_COMCODE_PAGE_CHILDREN.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_MAIN_COMCODE_PAGE_CHILDREN.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_MAIN_QUOTES.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_MAIN_QUOTES.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_MAIN_QUOTES.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_MAIN_SCREEN_ACTIONS.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_MAIN_SCREEN_ACTIONS.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_MAIN_SCREEN_ACTIONS.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_NO_ENTRIES.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_NO_ENTRIES.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/BLOCK_NO_ENTRIES.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/COMCODE_SURROUND.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/COMCODE_SURROUND.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/COMCODE_SURROUND.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/COMCODE_SURROUND.tpl/HYPERLINK.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/COMCODE_SURROUND.tpl/HYPERLINK.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/COMCODE_SURROUND.tpl/HYPERLINK.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/PARAGRAPH.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/PARAGRAPH.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/PARAGRAPH.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/SCREEN_TITLE.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/SCREEN_TITLE.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/COMCODE_SURROUND.tpl/SCREEN_TITLE.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/PARAGRAPH.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/PARAGRAPH.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/PARAGRAPH.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/POINTS_LEADER_BOARD.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/POINTS_LEADER_BOARD.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/POINTS_LEADER_BOARD.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/POINTS_LEADER_BOARD.tpl/POINTS_LEADER_BOARD_ROW.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/POINTS_LEADER_BOARD.tpl/POINTS_LEADER_BOARD_ROW.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/POINTS_LEADER_BOARD.tpl/POINTS_LEADER_BOARD_ROW.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/SCREEN_TITLE.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/SCREEN_TITLE.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/SCREEN_TITLE.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/STAFF_ACTIONS.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/COMCODE_PAGE_SCREEN.tpl/STAFF_ACTIONS.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/custom_globals.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/custom_globals.js/_self.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/email.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/email.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/facebook.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/facebook.js/_self.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/font_sizer.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/font_sizer.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/FONT_SIZER.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/FONT_SIZER.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/global.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/global.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/global.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/global.js/_self.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/GLOBAL_HTML_WRAP_mobile.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/GLOBAL_HTML_WRAP_mobile.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/HTML_HEAD.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/HTML_HEAD.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/HTML_HEAD.tpl/CSS_NEED.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/HTML_HEAD.tpl/CSS_NEED.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/HTML_HEAD.tpl/CSS_NEED.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/HTML_HEAD.tpl/CSS_NEED_INLINE.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/HTML_HEAD.tpl/CSS_NEED_INLINE.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/HTML_HEAD.tpl/CSS_NEED_INLINE.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/HTML_HEAD.tpl/JAVASCRIPT_NEED.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/HTML_HEAD.tpl/JAVASCRIPT_NEED.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/HTML_HEAD.tpl/JAVASCRIPT_NEED.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/JAVASCRIPT_NEED.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/JAVASCRIPT_NEED.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/JAVASCRIPT_NEED.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/menu__dropdown.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/menu__dropdown.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_dropdown.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_dropdown.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_dropdown.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_dropdown.tpl/MENU_BRANCH_dropdown.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_dropdown.tpl/MENU_BRANCH_dropdown.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_dropdown.tpl/MENU_BRANCH_dropdown.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_dropdown.tpl/MENU_BRANCH_dropdown.tpl/MENU_LINK_PROPERTIES.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_dropdown.tpl/MENU_BRANCH_dropdown.tpl/MENU_LINK_PROPERTIES.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_dropdown.tpl/MENU_LINK_PROPERTIES.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_dropdown.tpl/MENU_LINK_PROPERTIES.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_LINK_PROPERTIES.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_LINK_PROPERTIES.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/menu_popup.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/menu_popup.js/_self.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_STAFF_LINK.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_STAFF_LINK.tpl/_instance_calls.txt
./screens/root/start/GLOBAL_HTML_WRAP.tpl/MENU_STAFF_LINK.tpl/_self.tpl
./screens/root/start/GLOBAL_HTML_WRAP.tpl/modalwindow.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/modalwindow.js/_self.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/news.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/news.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/no_cache.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/no_cache.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/notification_poller.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/notification_poller.js/_self.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/notifications.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/notifications.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/personal_stats.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/personal_stats.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/points.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/points.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/polls.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/polls.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/random_quotes.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/random_quotes.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/screen_actions.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/screen_actions.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/search.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/search.css/_self.css
./screens/root/start/GLOBAL_HTML_WRAP.tpl/staff.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/staff.js/_self.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/transitions.js
./screens/root/start/GLOBAL_HTML_WRAP.tpl/transitions.js/_self.js

This is very useful to power-users, but the relationship data now saved can be used for the remaining parts of this task.

Guest

2016-03-14 02:15

reporter   ~3436

Last edited: 2016-03-14 02:18

View 2 revisions

I have this mostly implemented now. What remains is the specifics about previewing, live previewing, and some very minor details

TODO...

Get resize dragging working when multiple tabs are open

Add show templates by addon sections to the file tree

List related templates underneath template editing tabs, with buttons to load them

If people want to manipulate individual files without browser JavaScript support, they can use /code_editor.php -- put out an accessibility message about this

Navigating away would present a window.confirm, checking that you are okay with losing unsaved changes (only if there are unsaved changes though).

Multiple preview buttons, works with all tabs at once
 - Lorem ipsum [may not be available]
 - Preview via selected screen [may not be available]
 - Preview via live [may not be available]

The template editing would not have live preview, but hovering over the selection tree would result in highlighting of any HTML DOM nodes directly under the template being edited. This might work with a glow effect.

All the "Change page rendering tools" stuff

Re-take screenshots for documentation, and update text

Screen Shot 2016-03-14 at 02.14.05.png (156,799 bytes)   
Screen Shot 2016-03-14 at 02.14.05.png (156,799 bytes)   

Chris Graham

2016-03-24 00:51

administrator   ~3492

Last edited: 2016-03-25 13:18

 More is now done. The TODO is now...

Multiple preview buttons, works with all tabs at once
 - Lorem ipsum [may not be available]
 - Preview via selected screen [may not be available]
 - Preview via live [may not be available]

The template editing would not have live preview, but hovering over the selection tree would result in highlighting of any HTML DOM nodes directly under the template being edited. This might work with a glow effect.

All the "Change page rendering tools" stuff

Re-take screenshots for documentation, and update text

Fix template editor revision history - currently I think it is broken, and it should work via AJAX

Make sure that "Theme editor" is always used to refer to the overall admin_themes module and "template editor" or "edit templates" for the template editor. It may use "Theme editor" instead of "template editor" in some places, and needs to be consistent. CSS files are now considered templates.

Chris Graham

2016-03-28 02:17

administrator   ~3503

It's finally all done, and it's glorious!

I don't know when v11 will be out, but anyone can test this within the feature__code_editing_update git branch.

Rishi Saravanan

2016-03-28 02:58

reporter   ~3504

Congratulations!

Issue History

Date Modified Username Field Change
2016-03-11 23:14 Chris Graham Note Added: 0003433
2016-03-14 02:15 Guest Note Added: 0003436
2016-03-14 02:15 Guest File Added: Screen Shot 2016-03-14 at 02.14.05.png
2016-03-14 02:18 Chris Graham Note Edited: 0003436 View Revisions
2016-03-24 00:51 Chris Graham Note Added: 0003492
2016-03-25 13:18 Chris Graham Note Edited: 0003492
2016-03-27 14:19 Chris Graham Relationship added related to 2348
2016-03-28 02:16 Chris Graham Status Not Assigned => Resolved
2016-03-28 02:16 Chris Graham Resolution open => fixed
2016-03-28 02:16 Chris Graham Assigned To => Chris Graham
2016-03-28 02:17 Chris Graham Note Added: 0003503
2016-03-28 02:58 Rishi Saravanan Note Added: 0003504
2017-11-20 00:18 Chris Graham Relationship added child of 3362