This is a new v11 feature that mandates members re-agree to the rules whenever an admin changes the declarations. The review_rules UI is in the join module since the initial rules agreement is in the same module.

This feature was implemented to comply with data protection legislation that mandates in some places we have on record a member's agreement to a site's rules and Terms of Service especially when children are involved. When the declarations change, we cannot automatically assume a member agrees to them; we have to physically request that they do to be in compliance.

What do you currently have set for your join declarations in your site's config? Check for any stray spaces or newlines as well in the text box even if it appears empty.

...you may have to check the database directly in the config table for this

Definitely a bug; it should not be asking you this on a fresh install unless you ran the setup wizard. And it should not be in an infinite loop. I just need to figure out how the bug is played out.

Declarations would have been the defaults, I think the fact the install was with no members/forums was the issue. Perhaps the join declaration code hasn't factored this option in. I deleted that install as I couldn't do anything except tick all three boxes just to be sent back to repeat the process.

It should; it's blank by default in v11 (which changed since v10) and it's not supposed to even prompt when it's blank. I'll look into it.

Hmm I'm looking in the code and the logic is sound. Something else seems to be at play. Is there any 'join_declarations' in your config database table? If so, what's its value?

I deleted that install. Will recreate once I get some time.