#5778 - Consider configurable point discounts

This is a spacer post for a website comment topic. The content this topic relates to: #5778 - Consider configurable point discounts
Automated message: This issue was created using the Report Issue Wizard on the Composr homesite.
"I had to eliminate the previous $consider_free behaviour because it was breaking the expected amount checks on transactions" - can you say more about this, and link to a commit?
https://gitlab.com/composr-foundation/composr/-/commit/b1e9d031797a5fc4014149f711e7b37209a5b1ac

$consider_free was resulting in transaction checks made entirely by points to fail validation because the handler cannot convert between points and currency (either an error about unknown currency POINTS, or it improperly expected an amount of money on the transaction when it should have been 0).
And that wouldn't have been fixable as a bug fix? I haven't look at that code in quite a while so I am rusty on it.
I tried bug-fixing it but fixing it one way ended up breaking the system in another way. I couldn't find a fix that worked other than pulling it and implementing a skeleton to support custom discount ratios.
0 guests and 0 members have recently viewed this.