#3470 - Change our approach to autofill

This is a spacer post for a website comment topic. The content this topic relates to: #3470 - Change our approach to autofill
Chris, I just renamed input[name="login_username"] to input[name="username"] as part of our standardization. This sadly kills easy grep-ability for the username field. If you intentionally omitted this case, we can simply revert this commit:
https://github.com/ocproducts/composr/commit/9a915682e88f7ba8bfac84dd85e6569d1d50bd88
Ok, that may be problematic, but with some work can be ok.

The handle_logins function reads it in to support a login *on any screen*.

However, if the join screen is sending it, we obviously won't want that to trigger it.

So I suggest we have something like a parameter named _active_login, and only if that's set to 1 it'll look for 'username'.

Additionally we need to make sure IDs are still distinct. Login block may show at same time as join page or login page, but IDs are globally unique within a page.
All done in the 'v11_redesign' branch.
0 guests and 0 members have recently viewed this.