View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 978 | Composr | core | public | 2013-01-16 09:48 | 2013-01-24 21:14 |
| Reporter | Robbie Goacher | Assigned To | Chris Graham | ||
| Priority | normal | Severity | feature | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 978: Tidying up the overlay system | ||||
| Description | 1) Use Javascript to dynamically resize a loaded overlay to fit the content. 2) Remove the big close/cancel buttons at the bottom of an overlay, and replace it them a visual 'X' in one of the upper corners (Like Lightbox2, but at the top: http://lokeshdhakar.com/projects/lightbox2/ ) 3) Get rid of the secondary overlay that you get after you've added an attachment. 4) When an overlay is open, the content behind the overlay should not be scrollable. | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
| Attached Files | |||||
| Time estimation (hours) | 4 | ||||
| Sponsorship open | |||||
|
|
Note that point '4' would not hold for the case where point '1' made the overlay larger than the screen. i.e. the internal scrollbar is removed, and the main page scrollbar used instead, which implies the main page would be scrollable. |
|
|
This is now developed. Testing will be conducted on the major browsers, then a v9/9.1 version will be back-ported. |
|
|
v9 patch added. Note this CSS change... FROM: .box.overlay { {$BETA_CSS_PROPERTY,box-shadow: 0px 0px 20px {$GET,dark_shadow};} } TO: .box.overlay { {$BETA_CSS_PROPERTY,box-shadow: 0px 0px 20px {$GET,dark_shadow};} overflow: visible; } .overlay_close_button { position: absolute; top: -16px; right: -16px; cursor: pointer; } Rishi, I'll be uploaded this for you manually, as it's not quite compatible with your version. |
|
|
Applied zip number 3 (overlay_improvements (2).zip). Scrolling back to the top from a very long overlay works great, but that fix created an opposite situation... Now when using the "quick reply" at the bottom of a thread to reply, clicking on the "View all emoticons" link sends you to the top of the thread forcing you to scroll back down to finish your post. :) Is there a happy medium, or is it a "one or the other" type of thing? |
|
|
Updated again, so that scrolling to top doesn't occur for sub-window-sized overlays. |
|
|
Much better now! If my members find anything I'll report them here. |
|
|
Looks like it's working good on Firefox 18.0 (Linux) also. |
|
|
Found a bug. Image won't show in overlay when clicking on a thumbnail. Just get the little "working" icon. Doesn't work on v9.0.5 MSN hub and a satellite with patch. Works ok on a v9.0.5 MSN satellite without this improvement patch. |
|
|
Updated again. JAVASCRIPT_MODALWINDOW.tpl is the only changed file. |
|
|
Hello. Another new bug discovered by a user just now-- cannot upload photos in News article. When you choose a photo from your computer, you immediately go back to the news adding screen with no in-between screen to choose thumbnail or no thumbnail, etc. It says the photo is uploading, but the comcode doesn't show up in the article body window and you also don't get an option to add another photo. I emptied template and other caches to be sure. |
|
|
Ah, sorry about that, this was a version mismatch on your site. I have resolved it now. |
|
|
Great thanks. It does seem like that secondary overlay is not needed ("comcode has been added to the page....")-- ------- 3) Get rid of the secondary overlay that you get after you've added an attachment. ----------- |
|
|
This feature point was implemented in v10, however I didn't want to override too many v9/9.1 files. I can back-port this also if you like but essentially it is just removing the alert to a message at the top of the initial overlay, I thought it was pretty minor compared to the 'cost' of overriding a few extra files. |
|
|
sure, fine with me to leave it there for now |
|
|
"Updated again. JAVASCRIPT_MODALWINDOW.tpl is the only changed file." Bug squashed! |
