#6087 - It appears auto-banning in log_hack_attack_and_exit is not working for anyone
| Identifier | #6087 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | It appears auto-banning in log_hack_attack_and_exit is not working for anyone |
| Status | Completed |
| Tags |
Roadmap: v11 (custom) |
| Handling member | PDStig |
| Version | 11 beta7 |
| Addon | core |
| Description | It appears auto-banning in log_hack_attack_and_exit is not working for anyone. Several IP addresses on a site have exceeded the threshold and are not getting banned.
Investigate this. Perhaps create a new .log for debugging this. |
| Steps to reproduce | |
| Funded? | No |
| Commits |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".


Comments
After investigating, I noticed the cause of this was the cached negative bans being placed by the antispam system.
I added a new parameter on add_ip_ban allowing a ban to be forced (which bypasses the spam exclusion list and all negative bans in place).
The hack-attack forces it, any member-triggered areas of the UI to ban an IP forces it, and IP ban imports are also forced.
Additionally, I adjusted the IP ban removal function to not delete hack-attack records from the database (but instead silence them from the staff log). We don't want those records going away completely (in case of criminal investigations), just not showing up on the UI nor counting towards risk scores.