#6085 - Change get_username_from_human_name to process_username_discriminator
-
By PDStig
- Added
- 7 views
| Identifier | #6085 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Change get_username_from_human_name to process_username_discriminator |
| Status | Completed |
| Handling member | PDStig |
| Version | 11 beta5 |
| Addon | core_cns |
| Description | The current method of handling duplicate usernames in Composr is suffixing an incremental number at the end in parenthesis. This is generally considered bad practice for security reasons; we should instead use "discriminators", which is a hash (#) followed by a series of random numbers and letters (we will do 4 of them). This fix also optimises the function so we are not querying the database on every test / iteration to find a discriminator which is not used. In the future, we should consider an option allowing to force all (newly) registered accounts to receive a discriminator at the end of their specified username. And "get_username" should omit the discriminator when the display name parameter is true. |
| Steps to reproduce | |
| Funded? | No |
| Commits |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments