View Issue Details

IDProjectCategoryView StatusLast Update
5887Composrcorepublic2024-08-18 01:02
ReporterPDStig Assigned ToPDStig  
PriorityhighSeverityminor 
Status resolvedResolutionfixed 
Product Version10.0.48.beta 
Fixed in Version10.0.49 
Summary5887: Session cookies should always be HttpOnly / Secure where applicable
DescriptionComposr v10 does not currently meet current web standards for cookie security. Namely, Session cookies (defined as cookies with an expiration set to Session, not necessarily the Composr session cookie) are not getting the HttpOnly / Secure treatment when they should be, even when a cookie domain is set.

cms_setcookie should force HttpOnly / Secure on where applicable for session cookies to meet current web standards. global.js should do the same.
TagsRoadmap: v11, Type: Security
Attach Tags
Attached Files
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Relationships

related to 5888 ClosedPDStig Login loop when accessing CMS/Admin zones 
related to 5889 ResolvedPDStig CSRF tokens broken 
related to 5890 ClosedPDStig Consider additionally validating CSRF via cookie 

Activities

admin

2024-08-14 01:36

administrator   ~9178

Automated message: This issue was created using the Report Issue Wizard on the Composr homesite.

PDStig

2024-08-14 01:38

administrator   ~9179

v11 has the same problem, although only for the Secure property; it is setting HttpOnly like it should.

admin

2024-08-14 02:15

administrator   ~9180

Automated response: Session cookies should always be HttpOnly / Secure where applicable

This patch forces http-only on Session cookies and also correctly applies the Secure property when applicable.

This patch will not work without the updated global*.php files for 10.0.49. See GitLab to get them.

admin

2024-08-14 02:15

administrator   ~9181

Fixed in git commit 74309df6aa (https://gitlab.com/composr-foundation/composr/commit/74309df6aa - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

PDStig

2024-08-14 18:47

administrator   ~9192

Warning: This fix causes 5888 and 5889 . See those issues for resolutions.

PDStig

2024-08-18 01:02

administrator   ~9235

REVERTED in 10.0.50

Issue History

Date Modified Username Field Change
2024-08-14 01:36 PDStig Assigned To => user4172
2024-08-14 01:36 PDStig Status Not Assigned => Assigned
2024-08-14 01:38 PDStig Note Added: 0009179
2024-08-14 01:38 PDStig Tag Attached: Roadmap: v11
2024-08-14 03:16 PDStig Tag Attached: Type: Security
2024-08-14 18:47 PDStig Relationship added related to 5888
2024-08-14 18:47 PDStig Relationship added related to 5889
2024-08-14 18:47 PDStig Note Added: 0009192
2024-08-14 19:29 PDStig Relationship added related to 5890
2024-08-18 01:02 PDStig Note Added: 0009235