#5688 - load_html_page does not properly parse paths with query strings
-
By PDStig
- Added
- 4 views
| Identifier | #5688 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | load_html_page does not properly parse paths with query strings |
| Status | Completed |
| Tags |
Roadmap: v11 (custom) |
| Handling member | PDStig |
| Version | 10.0.47 |
| Addon | core |
| Description | If a path has a query string, then Composr fails to is_file check because the is_file check keeps the query string on it (resulting in the check returning false), thus Composr falls back to uploads/website_specific even if the file exists.
Check if this bug exists also in v11. |
| Steps to reproduce | |
| Additional information | This is a bug that must be fixed for a client, thus high priority. |
| Funded? | No |
| Commits |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
If a path has a query string, then Composr fails to is_file check because the is_file check keeps the query string on it (resulting in the check returning false), thus Composr falls back to uploads/website_specific even if the file exists.
This fix strips out query strings and fragments. It also adds site_html_pages hook functionality for additional processing of HTML pages.