View Issue Details

IDProjectCategoryView StatusLast Update
5688Composrcorepublic2024-04-28 22:22
ReporterPDStig Assigned ToPDStig  
PrioritynormalSeverityminor 
Status resolvedResolutionfixed 
Product Version10.0.47 
Fixed in Version10.0.48.beta 
Summary5688: load_html_page does not properly parse paths with query strings
DescriptionIf a path has a query string, then Composr fails to is_file check because the is_file check keeps the query string on it (resulting in the check returning false), thus Composr falls back to uploads/website_specific even if the file exists.

Check if this bug exists also in v11.
Additional InformationThis is a bug that must be fixed for a client, thus high priority.
TagsRoadmap: v11
Attach Tags
Attached Files
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Relationships

related to 5689 ResolvedPDStig Add site_html_pages hooks 

Activities

admin

2024-04-15 01:17

administrator   ~8602

Automated response: load_html_page does not properly parse paths with query strings

If a path has a query string, then Composr fails to is_file check because the is_file check keeps the query string on it (resulting in the check returning false), thus Composr falls back to uploads/website_specific even if the file exists.

This fix strips out query strings and fragments. It also adds site_html_pages hook functionality for additional processing of HTML pages.

admin

2024-04-15 01:17

administrator   ~8603

Fixed in git commit 29e22d14b1 (https://gitlab.com/composr-foundation/composr/commit/29e22d14b1 - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

PDStig

2024-04-28 22:22

administrator   ~8709

v11: https://gitlab.com/composr-foundation/composr/-/commit/b020ed9fabdbac62233bae89cfd1d08c37fdbae1

Issue History

Date Modified Username Field Change
2024-04-10 19:30 PDStig New Issue
2024-04-10 19:30 PDStig Status Not Assigned => Assigned
2024-04-10 19:30 PDStig Assigned To => user4172
2024-04-10 23:50 PDStig Relationship added related to 5689
2024-04-15 01:16 PDStig Tag Attached: Roadmap: v11
2024-04-15 01:18 PDStig Status Resolved => Assigned
2024-04-28 22:22 PDStig Status Assigned => Resolved
2024-04-28 22:22 PDStig Note Added: 0008709