View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 5614 | Composr | core | public | 2024-02-15 19:49 | 2024-02-26 01:05 |
| Reporter | TQ | Assigned To | PDStig | ||
| Priority | normal | Severity | major | ||
| Status | resolved | Resolution | fixed | ||
| Product Version | 10.0.45 | ||||
| Fixed in Version | 10.0.46 | ||||
| Summary | 5614: Error when updating password and smart topic notifications disabled | ||||
| Description | When a member tries to reset their password and do not have 'Smart topic notification' checked in their profile they receive the error: "The field cms_smart_topic_notification is required ... | ||||
| Additional Information | Patrick: Will also need ported to v11. Make sure admin_version in v11 is bumped to 19, not 18, as v10 had to be bumped to 18. Edit relevant install code that was originally for 18 to be for 19. | ||||
| Tags | Roadmap: v11 | ||||
| Attach Tags | |||||
| Attached Files | |||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
|
|
I have identified the issue. The field is set to required when installing Composr CMS when it should never have been that way. It was probably like that for all of version 10, not just when I put in field validation. But the bug only recently showed up because required field validation didn't exist server-side until 10.0.45. A resolution is going to be tricky because this involves deleting and re-creating the custom field (with required set to false) while migrating all of the member's values over to the newly-created field. As you mentioned your site has close to 100,000 members, I have to perform careful testing of the upgrade process (and simulate an upgrade on a site with 100,000 dummy members) before I make this fix available. |
|
|
This is not an option my members have naturally chosen as I believe they are unaware of the benefits, so the numbers run to just a couple of dozen. If it makes it easier, I will note down those members that use this feature and re-entered their preference manually so that the field can be recreated without content. |
|
|
That would make it easier, but I must think of the broader implications. Your situation might not be true for other people who would also have the same bug. Therefore, I still have to proceed with the migration route. |
|
|
Automated response: Smart topic notifications CPF was required when it should not be Smart topic notifications CPF was required when it should not be. This patch fixes the CPF by editing it so it is not required, and thus won't trigger the server-side field validation. This is a substantial fix! Take great care when applying it. Read all directions below carefully: 1. MAKE A BACKUP of your website and TEST THE BACKUP to make sure it works. 2. Extract the files from this archive into your Composr installation; replace files when prompted. 3. Log in to your site as an admin. 4. Go to the Admin Zone > Structure > Addons > Module management 5. Select Admin Zone 6. Scroll down to admin_version. It should say that it requires an upgrade. 7. Click the action button to upgrade the module. 8. You should get a successful message within a few seconds. NOTE: This bug fix was only tested on the Conversr forum driver. It might not work with other unsupported drivers. |
|
|
Fixed in git commit 635d11ecdc (https://gitlab.com/composr-foundation/composr/commit/635d11ecdc - link will become active once code pushed to GitLab) A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/). |
|
|
TQ please report to me when you can if the above hotfix fixes the bug. Thank you. I went a different approach to fixing the issue which is much more memory / resource friendly and did not require migrating field data. On a test site with 100,000 members, it only took about 2-3 seconds for the module to upgrade. |
|
|
Perfect! Thank you for both the fix and the detailed instructions. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-02-15 19:49 | TQ | New Issue | |
| 2024-02-23 18:59 | PDStig | Note Added: 0008344 | |
| 2024-02-23 19:01 | PDStig | Note Edited: 0008344 | |
| 2024-02-23 21:43 | PDStig | Note Edited: 0008344 | |
| 2024-02-23 21:43 | PDStig | Note Edited: 0008344 | |
| 2024-02-23 21:45 | PDStig | Assigned To | => user4172 |
| 2024-02-23 21:45 | PDStig | Status | Not Assigned => Assigned |
| 2024-02-24 07:59 | TQ | Note Added: 0008349 | |
| 2024-02-24 17:25 | PDStig | Note Added: 0008350 | |
| 2024-02-24 19:18 | PDStig | Note Added: 0008353 | |
| 2024-02-24 19:24 | PDStig | Tag Attached: Roadmap: v11 | |
| 2024-02-24 19:25 | PDStig | Additional Information Updated | |
| 2024-02-25 14:36 | Guest | Note Added: 0008354 | |
| 2024-02-25 16:00 | PDStig | Status | Assigned => Resolved |
| 2024-02-25 16:00 | PDStig | Resolution | open => fixed |
| 2024-02-25 22:33 | PDStig | Summary | Error when updating password => Error when updating password and smart topic notifications disabled |
| 2024-02-26 01:05 | PDStig | Note Edited: 0008344 |
