#5451 - Copy _config.php to _config.php.bak when installing over another install
-
By PDStig
- Added
- 4 views
| Identifier | #5451 |
|---|---|
| Issue type | Trivial issue (does not break functionality) |
| Title | Copy _config.php to _config.php.bak when installing over another install |
| Status | Completed |
| Handling member | PDStig |
| Version | 10.0.43 |
| Addon | installer |
| Description | The installer really should be copying the current _config.php to _config.php.bak when running over a current install. Sometimes, people may have git_repos() switches in their config file. And the installer will erase this.
Port this to v11 as well. Add new .htaccess and web.config rules to block access to _config.php.bak. Modify the warning screen on step 5 when overwriting an install to include information about this happening and what the user might need to do after install (copy stuff from .bak back into _config.php). Actually, the warning screen should probably be more "warning"ish and draw more attention; it's a critical screen. |
| Steps to reproduce | |
| Funded? | No |
| Commits |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
We should be backing up _config.php when running the installer over an existing install. Members might have custom configs depending on git branches which are otherwise lost. This fix will make the installer create a _config.php.bak.* file (* is the current timestamp).