View Issue Details

IDProjectCategoryView StatusLast Update
5271Composrcore_permission_managementpublic2024-07-24 21:17
ReporterPDStig Assigned ToChris Graham  
PrioritynormalSeverityfeature 
Status assignedResolutionopen 
Summary5271: Catalogue category permissions: intuition / labeling issues
DescriptionThe "Defaults (all gray)" option for permissions should mention it is showing inheritance.

Also, catalogue category permission defaults may not be correctly showing inheritance from the permissions of the catalogue itself.
Steps To Reproduce1. Deny add entry permission to all usergroups on a catalogue.
2. Add a new category to the catalogue; notice defaults still show + for add entry on usergroups.
TagsRoadmap: v11
Attach Tags
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Activities

PDStig

2023-11-04 07:27

administrator   ~8010

Last edited: 2023-11-04 07:32

Label has been fixed for a while now, but perhaps categories should default to "Defaults (all gray)".

Think of it as a tree. Catalogues default to permissions based on set privileges, which is fine. But categories are branches of the catalogue. Therefore, categories should default to "Defaults" / inherit from the catalogue, but currently they also take from submission privileges by default.

We should also check to make sure that, should a catalogue's permissions get changed later, that the categories set to Defaults match the new permissions.

Chris Graham

2024-07-23 16:04

administrator   ~8891

That's not how it works under-the-hood in Composr. Categories don't inherit permissions from Catalogues. Instead, it's a series of successive checks that need to pass. I think of it like barriers. It's a subtle distinction, and you could even argue a distinction without a difference in this case, but to try and make the UI hide how the system is actually working could be a big can of worms. I'd also advise not trying to mask over the subtle distinction as it becomes important to understand in other cases, like view permissions of pages vs zones. Composr isn't really a hierarchical system outside of category trees, it's a modular system.

PDStig

2024-07-23 16:40

administrator   ~8894

So if I'm understanding correctly, a permission / privilege is checked for itself (the category) and its parent (the catalogue), and if either is denied (even if the other is accepted) then the whole thing is denied. E.g. all of the checks must pass to have that permission or privilege.

Is this correct?

Chris Graham

2024-07-24 21:03

administrator   ~8904

Yes

PDStig

2024-07-24 21:11

administrator   ~8907

Last edited: 2024-07-24 21:11

Got it. Then I'm guessing there's no benefit to matching a category's permission with the catalogue's then. E.g. it is redundant.

Chris Graham

2024-07-24 21:17

administrator   ~8908

Our current implementation us not intuitive to many people, so I wouldn't say there's no way to improve it. But it'd have to be explained in the UI rather than just shown as inherited. Or we'd have to gut the system and change it to pure inheritance, which probably would lose something in the process. Either way, lots more work than just tweaking an interface.

Add Note

View Status
Note
Upload Files
Maximum size: 32,768 KiB

Attach files by dragging & dropping, selecting or pasting them.
You are not logged in You are not logged in. This means you will not get any e-mail notifications. And if you reply, we will not know for sure you are the original poster of the issue.

Issue History

Date Modified Username Field Change
2023-02-06 18:59 PDStig New Issue
2023-02-06 18:59 PDStig Status Not Assigned => Assigned
2023-02-06 18:59 PDStig Assigned To => Chris Graham
2023-02-26 18:29 Chris Graham Category General => General / Uncategorised
2023-11-04 07:27 PDStig Note Added: 0008010
2023-11-04 07:28 PDStig Note Edited: 0008010
2023-11-04 07:30 PDStig Note Edited: 0008010
2023-11-04 07:32 PDStig Note Edited: 0008010
2024-03-30 14:00 PDStig Tag Attached: Roadmap: v11
2024-03-30 14:00 PDStig Project Composr alpha bug reports => Composr
2024-03-30 14:33 PDStig Category General / Uncategorised => core_permission_management
2024-07-23 16:04 Chris Graham Note Added: 0008891
2024-07-23 16:40 PDStig Note Added: 0008894
2024-07-24 21:03 Chris Graham Note Added: 0008904
2024-07-24 21:11 PDStig Note Added: 0008907
2024-07-24 21:11 PDStig Note Edited: 0008907
2024-07-24 21:17 Chris Graham Note Added: 0008908