View Issue Details

IDProjectCategoryView StatusLast Update
4822Composrgalleriespublic2022-01-31 03:52
ReporterChris Graham Assigned ToChris Graham  
PriorityhighSeverityminor 
Status resolvedResolutionfixed 
Product Version10.0.41 
Fixed in Version10.0.42 
Summary4822: Gallery narrow-in functionality should check permissions
DescriptionIf the galleries are configured with narrow-in enabled (or equivalent Selectcode is given to the main_gallery_embed block) then:

1) We should check category permissions for whatever galleries descendant entries are in. Most webmasters would assume that gallery media thumbnails would not be visible if that gallery media is in a gallery without access to the current user. While this is not made explicit (so I am not filing this as a security issue), it is the right UX choice.
2) We must disable cacheing on the block, as member-level privileges may be involved.
 
If narrow-in is *not* being used we do not need to check permissions as the block may assume by its use by the webmaster that permission to see the output is granted within context.
TagsNo tags attached.
Attach Tags
Attached Files
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Relationships

related to 4765 ResolvedChris Graham Gallery items set as Members only outputs thumbnails for Guests 

Activities

admin

2022-01-31 03:51

administrator   ~7344

Fixed in git commit 736637667 (https://gitlab.com/composr-foundation/composr/commit/736637667 - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Issue History

Date Modified Username Field Change
2022-01-31 03:52 Chris Graham Relationship added related to 4765
2022-01-31 03:52 Chris Graham Summary Gallery narrow-in functionality should check privileges => Gallery narrow-in functionality should check permissions
2022-01-31 03:52 Chris Graham Description Updated