| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 4766 | Composr | galleries | public | 2022-01-16 07:21 | 2022-01-19 16:53 |
| Reporter | Adam Edington | Assigned To | Chris Graham | ||
| Priority | normal | Severity | major | ||
| Status | resolved | Resolution | fixed | ||
| Product Version | 10.0.39 | ||||
| Fixed in Version | 10.0.40 | ||||
| Summary | 4766: Non-flow mode box alignment issue | ||||
| Description | Have tried this layout on two different installs. After the 5th entry the boxes start aligning to the right and certain titles are not being trimmed to fit the box. Trying to find where the title comes from is also very challenging (maybe it's just me). | ||||
| Tags | No tags attached. | ||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
|
|
Automated response: Ratings on gallery media will cause overflow in default grid alignment When some gallery media as ratings and some doesn't, the grid layout is thrown off. Technical explanation: There are two issues: 1) There is margin collapsing on the paragraph to the left, but not on the rating to the right. This makes the rating taller. 2) The stars are still slightly taller than the paragraph to the left in some situations. |
|
|
Fixed in git commit ddb3c74f2 (https://gitlab.com/composr-foundation/composr/commit/ddb3c74f2 - link will become active once code pushed to GitLab) A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/). |
|
|
This has fixed the layout, still having problems with the Title (which seems to be causing the issue in the image on just 1 entry). gallery_media_title_cropped max-width set to 100px instead of the default 120px doesn't seem to have any effect. Using the theme tools "Show template edit links" has the entry displaying fine on the preview, so I have no idea why this entry is deformed. title.jpeg (23,141 bytes) |
|
|
Ok so I think you've taken off the template-based truncation. Which is fine, because that technique isn't so great anyway. CSS is better. I can't see any default styles on gallery_media_title_cropped, so I think you put the 100px on then the 120px on. The issue you seem to be having is it's wrapping. Do this... .gallery_media_title_cropped { max-width: 120px; white-space: nowrap; overflow-x: hidden; text-overflow: ellipsis; } This will force it onto one line with a max width, and add a "..." via CSS. |
|
|
Oh wait, disregard, now I see what you're referring to. I'll post again in a minute. |
|
|
Ok sorry I see what you were referring to. I was searching the code and didn't see it, but now I do. It basically is doing what I just said, but I think it's not working because I think you changed... {$TRUNCATE_LEFT,{TITLE},23,0,0} in GALLERY_VIDEO & GALLERY_IMAGE.tpl to just {TITLE} You need to change it to <span>{TITLE}</span> Otherwise the ".gallery_media_title_cropped>span" CSS rule won't hit it. The TRUNCATE_LEFT is adding a span itself, so you need to put it back in manually. |
|
|
I hadn't changed anything in that paragraph but replacing that Truncate code with the span fixed the issue. Setting a max-width of 155px has everything looking hunky dory. Thanks. |
