#4760 - SU issue with "Guest" on multilingual sites
| Identifier | #4760 |
|---|---|
| Issue type | Trivial issue (does not break functionality) |
| Title | SU issue with "Guest" on multilingual sites |
| Status | Completed |
| Handling member | Chris Graham |
| Version | 10.0.39 |
| Addon | core_forum_drivers |
| Description | The member ‘Visiteur’ does not exist. Same for "Гость" etc. |
| Steps to reproduce | |
| Funded? | No |
| Commits |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".


Comments
Perhaps this is a valid point. Composr is mapping the username by language pack and ignoring what is in the DB, so it is inconsistent in its handling at least.
In some parts of Composr we use the 'GUEST' language string, and others we use the field value from the guest member row in the f_members table.
That is fine, but it means that we need to automatically recognise the contents of the 'GUEST' language string as guest (in whatever language is currently active) as that guest user, as well as the value from the database.
if ($ks == do_lang('GUEST', null, null, null, fallback_lang())) {
$ks = do_lang('GUEST');
}
It maps "Guest" to the equivalent in the current user's language pack and tries to look up that in the database, which will only succeed if the Guest user in the database was initially created with the language the current user is on.
My fix does resolve the issue, as well as the issue I thought this was about.