View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 3824 | Composr | core | public | 2019-06-17 18:24 | 2020-09-12 01:32 |
| Reporter | Chris Graham | Assigned To | Chris Graham | ||
| Priority | normal | Severity | feature | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 3824: Rep-image and thumbnail refresh | ||||
| Description | Currently the default is for rep-images to be sized to thumbnail size when you upload them (resize_rep_image function). This makes little sense for multiple reasons: 1) Rep-image size is not necessarily going to have anything to do with thumbnail size. For example, the image in the corner of a news article box is smaller than thumbnail size. 2) Realistically in the modern day we're going to have to resize content images dynamically for multiple contexts - Open Graph, rep-images in boxes, thumbnail grids, different designs of thumbnail grids, different device types (responsive design). Likewise, thumbnails may also need to be in different sizes too. In both situations, we should be sizing images dynamically (with caching) using the Tempcode $THUMBNAIL symbol. This way, it's handled cleanly/flexibly at the template layer. So I think we should remove any code that is pre-sizing down thumbnails. The configuration option for thumbnail size should just be a display-layer default, and define the minimum size of thumbnail that may be uploaded. | ||||
| Tags | Roadmap: v11 | ||||
| Attach Tags | |||||
| Time estimation (hours) | 16 | ||||
| Sponsorship open | |||||
| related to | 3354 | Not Assigned | Guest | Tile-based activity feed |
| related to | 3825 | Resolved | Chris Graham | Validating image inputs |
|
|
I don't like how post_param_image and resize_rep_image and check_form_field_image are defined in themes2.php, should be images2.php. |
|
|
Note that this change is a big one. A lot of code has been restructured. Thumbnails are now in most cases something that are generated on the fly - with the exceptions of videos and attachments and the media system in general, which support explicit thumbnails as they may not be auto-generatable. The thumbnail editor addon has gone because you no longer have one thumbnail for resources but potentially many generated on-the-fly. A clear distinction is maintained between thumbnails ("an alternate representation of a visual resource") and representative images (just any image the webmaster has chosen to represent something that is not intrinsically visual). GD is now strictly required. It was always in the requirements but we did still unofficially support not having it. Not anymore. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-06-17 18:24 | Chris Graham | New Issue | |
| 2019-06-17 18:25 | Chris Graham | Relationship added | related to 3825 |
| 2019-06-27 17:58 | Chris Graham | Tag Attached: Roadmap: v11 | |
| 2019-07-03 13:46 | Chris Graham | Note Added: 0006023 | |
| 2019-07-03 13:51 | Chris Graham | Note Edited: 0006023 | |
| 2019-11-15 00:13 | Chris Graham | Description Updated | |
| 2020-02-20 02:19 | Chris Graham | Relationship added | related to 3354 |
| 2020-03-07 21:21 | Chris Graham | Assigned To | => Chris Graham |
| 2020-03-07 21:21 | Chris Graham | Status | Not Assigned => Assigned |
| 2020-09-11 23:02 | Chris Graham | Time estimation (hours) | 3 => 16 |
| 2020-09-12 01:01 | Chris Graham | Status | Assigned => Resolved |
| 2020-09-12 01:01 | Chris Graham | Resolution | open => fixed |
| 2020-09-12 01:32 | Chris Graham | Note Added: 0006696 |
