#3636 - Configuration option setting checks

Identifier #3636
Issue type Feature request or suggestion
Title Configuration option setting checks
Status Completed
Handling member Chris Graham
Addon core_configuration
Description There are a number of cases where changing configuration options may be destructive.

Currently some are hard-coded in admin_config.php:

1) "Make sure we haven't locked ourselves out due to URL Scheme support" - you can't set a URL Scheme if the rewrites aren't configured first
2) "Make sure we haven't just locked staff out" - if the site name is changed some forum layer renaming has to happen for MSNs with separate staff rosters
3) "Empty thumbnail cache if needed" - if the thumbnail size is changed, the thumbnail cache needs emptying
4) "Empty language cache if needed" - if US English is toggled, the language cache needs emptying

And we should also have:

1) "Make sure setting e-mail address login [one_per_email_address=2] doesn't lock the current admin out because they have no e-mail address"

We should implement this all in a cleaner way. Each config hook should have a check method, which checks the new value is valid / does extra cleanup that is needed. That's more extendible.
Steps to reproduce

Funded? No
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated