#3616 - Broken uploads

Identifier #3616
Issue type Feature request or suggestion
Title Broken uploads
Status Completed
Handling member Salman
Addon General / Uncategorised
Description As discussed on Skype
Steps to reproduce

Additional information Salman, 17:46
ok (y) just found some instances I missed when hyphenating id attributes

Salman, 17:52
click_link(document.getElementById('uploadButton_file'+num_attachments));

is num_attachments a local variable or global aka window.num_attachments?

oh looks like the latter

Salman, 18:33
the submit_form_on_enter stuff was easy, just add data-submit-on-enter="1" to the desired elements haha




click_link(document.getElementById('uploadButton_file'+num_attachments));

^ is document.getElementById('uploadButton_file'+num_attachments) a button or a link?

it won't work for a button as it looks like I replaced click_link() with $util.navigate(), which doesn't actually trigger a click event anymore rather only redirects to the value of the [href] attribute

19:46
I believe uploadButton_file is a button created dynamically in plupload.js
var settings = getUploaderSettings(name, pageType, postingFieldName, filter);
settings.progress_target = 'fs-upload-progress-' + name;
settings.required = rep.classList.contains('required');
settings.browse_button = 'upload-button-' + name;
settings.drop_element = 'txt_filename_' + name;
settings.container = 'main-div-' + name;
there it is, yes inconsistent

Salman, 19:50
Ok I will check it after you commit.
Funded? No
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated