#3570 - Join our banner scheme link
| Identifier | #3570 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Join our banner scheme link |
| Status | Completed |
| Handling member | Chris Graham |
| Addon | core_comcode_pages |
| Description | Clicking this link (from the advertise page) to the CMS zone banners module loads the login page as expected when viewing as a guest but the page doesn't have a header (just the content and the footer). This is likely due to the CMS zone having the admin theme. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".


Comments
We cannot show an empty menu, and I think it is appropriate to have a link in the template, and we don't want to do an admin theme redesign, so I don't think there's any change here.
We could probably put the logo at the top of the theme if there's no menu there. I'll create an issue for that, but it certainly wouldn't get done as a bugfix in v10 because it would be a major styling change.
Even a welcome zone with no panels would display the header and background colour from the default theme (I think). But yes, the logo instead of a menu would be good too and might more a lot more sense from a developer perspective. I am, as ever, talking from an end user perspective.
When it comes to v10, I am going to be very conservative about what changes.
It is supposed to show a very cut down alternative menu. But if the single public zone option is off, it fails because it fails on permissions to the site zone for guests - the result is an empty menu.
I fixed that, and did a bit more tuning.