#3446 - Tray expander images seem to be breaking hi-dpi
-
By Chris Graham
- Added
- 2 views
| Identifier | #3446 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Tray expander images seem to be breaking hi-dpi |
| Status | Completed |
| Handling member | Salman |
| Addon | General / Uncategorised |
| Description | The 'theme_images' test is failing...
Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme default: 2x/trays/contract at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171] Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme default: 2x/trays/contract2 at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171] Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme default: 2x/trays/expand at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171] Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme default: 2x/trays/expand2 at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171] Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme admin: 2x/trays/contract at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171] Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme admin: 2x/trays/contract2 at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171] Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme admin: 2x/trays/expand at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171] Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme admin: 2x/trays/expand2 at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171] Looking at the JS code, I can't see it using srcset anymore. We shouldn't be upscaling/downscaling with low quality blending code, we have (until we switch to SVGs anyway) separate optimised images for normal-dpi and high-dpi. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments