#2902 - If change detection returns 1, but refresh not to happen, notification sound plays repeatedly
-
By PDStig
- Added
- 5 views
| Identifier | #2902 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | If change detection returns 1, but refresh not to happen, notification sound plays repeatedly |
| Status | Closed (cannot reproduce) |
| Handling member | Chris Graham |
| Addon | core |
| Description | If change detection script detects a change on the page you're on (eg. tickets, or in my case the forums), and due to some circumstance, the content is not to be refreshed (such as activating quick reply), the new notification sound keeps playing every time change detection script runs. |
| Steps to reproduce | |
| Additional information | Chrome Windows 10 lovinity.org Composr CMS 10 RC20 |
| Related to | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
INTERNALISED_AJAX_SCREEN.tpl has changed now. Maybe you need to update your code to reflect that?
INTERNALISED_AJAX_SCREEN.tpl
setup interval calling detect_change in internalised_ajax_screen.js
internalised_ajax_screen.js
detects change
clears interval
calls callback in INTERNALISED_AJAX_SCREEN.tpl
INTERNALISED_AJAX_SCREEN.tpl
if active quick reply post, stops
calls block refresh
calls _detected_change in internalised_ajax_screen.js
internalised_ajax_screen.js
makes sound
As you can see, the interval gets cleared (so no loop), and the sound only ever happens if there's no active quick reply (so no sound).