View Issue Details

IDProjectCategoryView StatusLast Update
2576Composrinstallerpublic2016-10-27 00:21
ReporterChris Graham Assigned ToChris Graham  
PrioritynormalSeverityfeature 
Status resolvedResolutionfixed 
Summary2576: Automated install.php removal
DescriptionWe do not need to warn about deleting install.php IF we are on a SuEXEC server. We can delete directly when global2.php detects it there (assuming dev mode isn't on, in which case we leave it alone).
TagsNo tags attached.
Attach Tags
Time estimation (hours)1
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Activities

PDStig

2016-10-27 00:09

administrator   ~4482

Crap this is already resolved. I was gonna say may wish to think about this one. Some CMS systems feel it is ideal to leave the installer in place and require the user to remove it themselves. That way, if the user wants to make a copy of the installer, they can. Or, if they want to use it for a later time, they can. Some systems will also keep the installer but lock it down.

Chris Graham

2016-10-27 00:12

administrator   ~4483

Last edited: 2016-10-27 00:13

I am happy with it though. I did think maybe they'd want to go back, but on balance I thought this best. Tidiness is better. Locking is extra complexity for the user. Re-upload is easy.

There is a safeguard. The installer only deletes if you follow the link at the end of the installer. That link includes a "safe to delete flag". That way tangential calls to index.php are non-destructive.

PDStig

2016-10-27 00:19

administrator   ~4484

Ahh okay that's good. I thought it was automatic as in the user didn't really have a choice.

Chris Graham

2016-10-27 00:21

administrator   ~4485

Well they don't have a choice, just it's part of the designed flow, rather than any other arbitrary other flow.

Issue History

Date Modified Username Field Change
2016-05-06 20:48 Chris Graham New Issue
2016-10-19 16:29 Chris Graham Status Not Assigned => Resolved
2016-10-19 16:29 Chris Graham Resolution open => fixed
2016-10-19 16:29 Chris Graham Assigned To => Chris Graham
2016-10-27 00:09 PDStig Note Added: 0004482
2016-10-27 00:12 Chris Graham Note Added: 0004483
2016-10-27 00:13 Chris Graham Note Edited: 0004483
2016-10-27 00:19 PDStig Note Added: 0004484
2016-10-27 00:21 Chris Graham Note Added: 0004485