View Issue Details

IDProjectCategoryView StatusLast Update
2375Composrcorepublic2016-04-05 17:29
ReporterPDStig Assigned ToChris Graham  
PriorityimmediateSeverity@80@ 
Status resolvedResolutionfixed 
Summary2375: Composr 10RC2: Editing in-line text elements on profile about page resets everything, including earned points
DescriptionIn-line editing is a nightmare especially on profile about section. When you edit a field on someone's profile page, all the integer type fields, including points, reset to zero. This can result in critical unintentional loss of points and data.
TagsNo tags attached.
Attach Tags
Time estimation (hours)
Sponsorship open

Sponsor

Date Added Member Amount Sponsored

Activities

PDStig

2016-04-05 06:29

administrator   ~3530

There are several other issues with inline editing still as well, such as this when editing the title of a private topic.

To be honest Chris, I think at this point inline editing should be pulled from the 10.0 branch of Composr. It was added in too late and is making for very unstable release candidates. I think it should be pushed back to 10.1 beta 1.


#0 _fatal_exit(Tempcode Object ([code_to_preexecute] => Array ([do_runtime_57035adab3c326.95951318_7] => $tpl_funcs['do_runtime_57035adab3c326.95951318_7']="echo ecv(\$cl,array(),2,\"QUERY_FAILED\",array(\"UPDATE 43SO_f_forums SET \\n f_cache_num_topics=(f_cache_num_topics+0),\\n f_cache_num_posts=(f_cache_num_posts+0),f_cache_last_topic_id=82,\\n f_cache_last_title='Explanation for sudden loss of points',\\n f_cache_last_time=1459837623,\\n f_cache_last_username='Lovinity',\\n f_cache_last_member_id=2,\\n f_cache_last_forum_id=NULL\\n WHERE id= LIMIT 1\",\"You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'LIMIT 1' at line 9\"));";
),[seq_parts] => Array ([0] => Array ([0] => Array ([0] => do_runtime_57035adab3c326.95951318_7,[1] => Array (),[2] => 2,[3] => QUERY_FAILED,[4] => ))),[preprocessable_bits] => Array (),[pure_lang] => 1,[evaluate_echo_offset_group] => 0,[evaluate_echo_offset_inner] => 0,[codename] => :container,[preprocessed] => ,[cached_output] => Unfortunately a query has failed [UPDATE 43SO_f_forums SET
f_cache_num_topics=(f_cache_num_topics+0),
f_cache_num_posts=(f_cache_num_posts+0),f_cache_last_topic_id=82,
f_cache_last_title='Explanation for sudden loss of points',
f_cache_last_time=1459837623,
f_cache_last_username='Lovinity',
f_cache_last_member_id=2,
f_cache_last_forum_id=NULL
WHERE id= LIMIT 1] [<strong>You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'LIMIT 1' at line 9</strong>],[children] => ,[fresh] => )) called at [/var/www/vhosts/lovinity.org/httpdocs/sources/global2.php:903]
#1 fatal_exit(Tempcode Object ([code_to_preexecute] => Array ([do_runtime_57035adab3c326.95951318_7] => $tpl_funcs['do_runtime_57035adab3c326.95951318_7']="echo ecv(\$cl,array(),2,\"QUERY_FAILED\",array(\"UPDATE 43SO_f_forums SET \\n f_cache_num_topics=(f_cache_num_topics+0),\\n f_cache_num_posts=(f_cache_num_posts+0),f_cache_last_topic_id=82,\\n f_cache_last_title='Explanation for sudden loss of points',\\n f_cache_last_time=1459837623,\\n f_cache_last_username='Lovinity',\\n f_cache_last_member_id=2,\\n f_cache_last_forum_id=NULL\\n WHERE id= LIMIT 1\",\"You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'LIMIT 1' at line 9\"));";
),[seq_parts] => Array ([0] => Array ([0] => Array ([0] => do_runtime_57035adab3c326.95951318_7,[1] => Array (),[2] => 2,[3] => QUERY_FAILED,[4] => ))),[preprocessable_bits] => Array (),[pure_lang] => 1,[evaluate_echo_offset_group] => 0,[evaluate_echo_offset_inner] => 0,[codename] => :container,[preprocessed] => ,[cached_output] => Unfortunately a query has failed [UPDATE 43SO_f_forums SET
f_cache_num_topics=(f_cache_num_topics+0),
f_cache_num_posts=(f_cache_num_posts+0),f_cache_last_topic_id=82,
f_cache_last_title='Explanation for sudden loss of points',
f_cache_last_time=1459837623,
f_cache_last_username='Lovinity',
f_cache_last_member_id=2,
f_cache_last_forum_id=NULL
WHERE id= LIMIT 1] [<strong>You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'LIMIT 1' at line 9</strong>],[children] => ,[fresh] => )) called at [/var/www/vhosts/lovinity.org/httpdocs/sources/database/mysqli.php:249]
2 Database_Static_mysqli->db_query(UPDATE 43SO_f_forums SET
f_cache_num_topics=(f_cache_num_topics+0),
f_cache_num_posts=(f_cache_num_posts+0),f_cache_last_topic_id=82,
f_cache_last_title='Explanation for sudden loss of points',
f_cache_last_time=1459837623,
f_cache_last_username='Lovinity',
f_cache_last_member_id=2,
f_cache_last_forum_id=NULL
WHERE id=, Array ([0] => mysqli Object ([affected_rows] => ,[client_info] => ,[client_version] => ,[connect_errno] => ,[connect_error] => ,[errno] => ,[error] => ,[error_list] => ,[field_count] => ,[host_info] => ,[info] => ,[insert_id] => ,[server_info] => ,[server_version] => ,[stat] => ,[sqlstate] => ,[protocol_version] => ,[thread_id] => ,[warning_count] => ),[1] => admin_tlc), 1, , , , , ) called at [/var/www/vhosts/lovinity.org/httpdocs/sources/database.php:1298]
3 DatabaseConnector->_query(UPDATE 43SO_f_forums SET
f_cache_num_topics=(f_cache_num_topics+0),
f_cache_num_posts=(f_cache_num_posts+0),f_cache_last_topic_id=82,
f_cache_last_title='Explanation for sudden loss of points',
f_cache_last_time=1459837623,
f_cache_last_username='Lovinity',
f_cache_last_member_id=2,
f_cache_last_forum_id=NULL
WHERE id=, 1, , , , , ) called at [/var/www/vhosts/lovinity.org/httpdocs/sources/database.php:1073]
4 DatabaseConnector->query(UPDATE 43SO_f_forums SET
f_cache_num_topics=(f_cache_num_topics+0),
f_cache_num_posts=(f_cache_num_posts+0),f_cache_last_topic_id=82,
f_cache_last_title='Explanation for sudden loss of points',
f_cache_last_time=1459837623,
f_cache_last_username='Lovinity',
f_cache_last_member_id=2,
f_cache_last_forum_id=NULL
WHERE id=, 1, , , 1) called at [/var/www/vhosts/lovinity.org/httpdocs/sources/cns_posts_action2.php:385]
5 cns_force_update_forum_caching(, 0, 0) called at [/var/www/vhosts/lovinity.org/httpdocs/sources/cns_topics_action2.php:145]
6 cns_edit_topic(82, !--:)abcUNLIKELY, !--:)abcUNLIKELY, 1634817353, 1634817353, 1634817353, 1634817353, 1634817353, !--:)abcUNLIKELY, Explanation for sudden loss of points, , 1, 1634817353) called at [/var/www/vhosts/lovinity.org/httpdocs/forum/pages/modules/topics.php:3458]
7 Module_topics->_edit_topic()
8 call_user_func(Array ([0] => Module_topics Object ([title] => ),[1] => _edit_topic)) called at [/var/www/vhosts/lovinity.org/httpdocs/forum/pages/modules/topics.php:221]
9 Module_topics->run() called at [/var/www/vhosts/lovinity.org/httpdocs/sources/zones.php:782]
10 load_module_page(forum/pages/modules/topics.php, topics, ) called at [/var/www/vhosts/lovinity.org/httpdocs/sources_custom/site.php:1179]
11 request_page(topics, 1) called at [/var/www/vhosts/lovinity.org/httpdocs/sources/ajax.php:370]
12 fractional_edit_script() called at [/var/www/vhosts/lovinity.org/httpdocs/data/fractional_edit.php:58]
Unfortunately a query has failed [UPDATE 43SO_f_forums SET
f_cache_num_topics=(f_cache_num_topics+0),
f_cache_num_posts=(f_cache_num_posts+0),f_cache_last_topic_id=82,
f_cache_last_title='Explanation for sudden loss of points',
f_cache_last_time=1459837623,
f_cache_last_username='Lovinity',
f_cache_last_member_id=2,
f_cache_last_forum_id=NULL
WHERE id= LIMIT 1] [You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'LIMIT 1' at line 9]

Chris Graham

2016-04-05 17:29

administrator   ~3531

Sorry about that.

Inline editing has been there for ages, but some of them weren't visible before due to a different bug.

I have hacked it as off on your site, and in RC3 it will behind an option that defaults to off.

All bugs I could find are fixed, including those reported here.

Issue History

Date Modified Username Field Change
2016-04-05 06:20 PDStig New Issue
2016-04-05 06:29 PDStig Note Added: 0003530
2016-04-05 16:56 Chris Graham Status Not Assigned => Resolved
2016-04-05 16:56 Chris Graham Resolution open => fixed
2016-04-05 16:56 Chris Graham Assigned To => Chris Graham
2016-04-05 17:29 Chris Graham Note Added: 0003531