View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
1977 | Composr alpha bug reports | General / Uncategorised | public | 2015-06-27 00:38 | 2015-07-10 12:38 |
Reporter | Jason Verhagen | Assigned To | Chris Graham | ||
Priority | normal | Severity | @70@ | ||
Status | resolved | Resolution | fixed | ||
Summary | 1977: Installer critical error bail out after recent git commit relating to caching | ||||
Description | The addition of the has_caching_for function in sources/caches.php results in an error when running install.php: Fatal error: Call to undefined function has_caching_for() in E:\xampp\htdocs\composr\sources\lang.php on line 453 Critical error – bailing out PHP [1] Call to undefined function has_caching_for() Stack trace… File -> E:\xampp\htdocs\composr\sources\minikernel.php Line -> 392 Function -> critical_error Args -> a:2:{i:0;s:6:"PASSON";i:1;s:52:"PHP [1] Call to undefined function has_caching_for()";} File -> E:\xampp\htdocs\composr\sources\minikernel.php Line -> 200 Function -> die_html_trace Args -> a:1:{i:0;s:52:"PHP [1] Call to undefined function has_caching_for()";} File -> E:\xampp\htdocs\composr\sources\minikernel.php Line -> 314 Function -> fatal_exit Args -> a:1:{i:0;s:52:"PHP [1] Call to undefined function has_caching_for()";} File -> E:\xampp\htdocs\composr\sources\minikernel.php Line -> 264 Function -> composr_error_handler Args -> a:4:{i:0;i:1;i:1;s:44:"Call to undefined function has_caching_for()";i:2;s:40:"E:\xampp\htdocs\composr\sources\lang.php";i:3;i:454;} Function -> catch_fatal_errors Args -> a:0:{} | ||||
Additional Information | I believe this only affects install.php. Reverting sources\lang.php line 453 back to the previous version resulted in the same error popping up in sources\lang_compile.php line 45. Adding require_code statements created additional errors. Adding the has_caching_for function directly into install.php seems to be the solution. | ||||
Tags | No tags attached. | ||||
Attach Tags | |||||
Sponsorship open | |||||
|
I didn't commit a fix to github for this since I'm not sure if adding that function to install.php is the appropriate fix, or if there is another source file the function could be moved to. |
|
Thanks. has_caching_for was introduced to replace some growingly-complex copy&pasted code. However the installer isn't quite Composr, doesn't use global2.php and doesn't load all the same dependencies. Correct fix was a function_exists guard to battleguard the shared parts of the framework the installer calls up. |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |