#1963 - Rewrite form submission as explicit rather than than using onsubmit, when JS enabled - and other changes
-
By Chris Graham
- Added
- 3 views
| Identifier | #1963 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Rewrite form submission as explicit rather than than using onsubmit, when JS enabled - and other changes |
| Status | Completed |
| Tags |
Type: Standards compliance (custom) |
| Handling member | Salman |
| Addon | core |
| Description | Browsers are deprecating synchronous AJAX, which means we can no longer do form validation with server-side checks as a part of onsubmit handling.
Instead we will have to make a click initiate checks then submit the form itself when done. That means major re-architecting. Additionally there other cases where we are using synchronous AJAX for safety reasons and we may need to implement JavaScript modality and progress spinners to handle this, as a safe alternative. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
Also the attachment code is extremely complicated.
All needs to be reviewed.
I haven't implemented any additional progress spinners or modals. Please have a look and guide where we might need them now. For forms we currently disable the submit button once pressed, this is more than 99% of the web does really.
BTW I am not a fan of the current dated code used for the <img> based progress spinners. We can have wholy CSS ones now, which can simply be triggered by adding a CSS class to the element being loaded. Tie that in with Promises and we can make it automatic, and not even have to deal with the hassle of adding/removing the class manually every time.
P.S: You may also want to review the work log.