1944: Spam post regression - Composr CMS feature tracker

ID	Project	Category	View Status	Date Submitted	Last Update

1944	Composr	General / Uncategorised	public	2015-06-01 12:52	2015-06-11 12:56

Reporter	Lhasadreams	Assigned To	Chris Graham
Priority	normal	Severity	feature
Status	resolved	Resolution	fixed

Summary	1944: Spam post regression
Description	Hi, On vwgolfmk1.org.uk we have implemented a system where a new user has to have their post validated by a moderator. This has worked well and cut our spam from kitchen sellers etc to zero. However today one got through, on their third post they were automatically promoted out of the validation group and into newbies. I am sure that this was fixed a while a go - perhaps it came back with the other work that Composr did for us a while a go. I have added a screen shot of the user that caused this from our audit log. Expected behaviour is that no group promotion and hence no points added unless the post is validated. I cannot see any validation of posts by a mod, unless the act of moving them to the moderated posts archive causes that. I have banned the user now. Cheers Ade
Tags	No tags attached.
Attach Tags	(Separate by ",")
Attached Files	2015-06-01_14-47-34.jpg (17,813 bytes) 2015-06-01_14-47-34.jpg (17,813 bytes)

Time estimation (hours)
Sponsorship open

Date Added	Member	Amount Sponsored

Chris Graham 2015-06-11 00:08 administrator ~2903	Background: I had designed it to hold off counting the new post until it was validated. This is because the post count raising is iterative, rather than doing a full recalculation. (For performance reasons) However, possibly a member post count cleanup caused it to be refreshed. Or moving from a forum with no post counts to one with them. I have now changed it so also it will not count unvalidated posts when it does a full recalculation.

Chris Graham 2015-06-11 00:18 administrator ~2904	Ah, also validation-respecting checks were needed for move-posts/move-topics/delete-posts/delete-topic, as these are working iteratively too. I have now done that.

Lhasadreams 2015-06-11 12:08 developer ~2908	Hi Chris, Had a guy today report that he cannot post in our Classified section. To do that you have to be in the Regular Group which requires 100 points. He is still in the Newbie group even though he has passed the 100 point mark with 165 points. It looks like the auto promotion failed. He has only done one post and one of the mods gave him points to get him promoted. Do you think that this fix could of broken the promotion ? His username is bubbadubba. I will probably manually add him to the Regular group now so that he can post in the Classifieds. Cheers Ade

Chris Graham 2015-06-11 12:56 administrator ~2910	Hi, I don't think I broke anything, no. But I think I know what happened. I think it is a lagginess. The code was running promotion checks before updating the run-time cache of the member's points. So I think that bumped it back one further action before it would go through. I have corrected that. I also noticed a potential where it would not bump up multiple rank spots in one go (i.e. leapfrogging), depending on database record order - that should be fixed now too.

Date Modified	Username	Field	Change
2023-02-26 18:29	Chris Graham	Category	General => General / Uncategorised