View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 1913 | Composr alpha bug reports | General / Uncategorised | public | 2015-05-23 00:56 | 2015-05-25 10:06 |
| Reporter | Adam Edington | Assigned To | Chris Graham | ||
| Priority | normal | Severity | @70@ | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 1913: v10 Donation Banner | ||||
| Description | Clicking on the Donate banner (which appears in a weird place on certain pages and not at all on others) gives the following white screen error. Notice: Undefined index: FORUM_DRIVER in C:\Program Files (x86)\EasyPHP-DevServer-14.1VC9\data\localweb\demos\composr\sources\database.php on line 475 Fatal error: Call to a member function get_drivered_table_prefix() on a non-object in C:\Program Files (x86)\EasyPHP-DevServer-14.1VC9\data\localweb\demos\composr\sources\database.php on line 475 | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
| Sponsorship open | |||||
|
|
Also opens the link in a new tab, which probably makes sense for an external url but not for the donation banner. |
|
|
A few points: - Couldn't reproduce main error, but fixed issue in API - Fixed issues on dev mode that happened when I tested - Made local URLs not open in new window - Weird placing of banner can happen now if an error happens mid-rendering of a page. This is due to the output streaming option (sends output as soon as page rendering starts, a big optimisation). - It will say missing page when you click these default banners, but if you go to add it will use a matching page template to bring in a default version of the page. This is intentional to reduce bloat, I never liked us having these hard-coded 'donate' and 'advertise' pages that came with the banners addon, far too big an assumption (deleting the default banners is still necessary, but that's far less intrusive than default pages). |
|
|
Okay, that all makes sense and glad you fixed it up some. |
|
|
There is actually a typo at the start of the banner itself, 'maintaing' |
|
|
Fixed |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |
