1610: Calendar block not correctly handling DST - Composr CMS feature tracker

ID	Project	Category	View Status	Date Submitted	Last Update

1610	Composr	calendar	public	2014-03-23 19:38	2014-03-24 16:14

Reporter	PDStig	Assigned To	Guest
Priority	high	Severity	minor
Status	resolved	Resolution	fixed

Summary	1610: Calendar block not correctly handling DST
Description	Composr: 9.0.12 Runs on: Linux Time Zone: America/New_York (Daylight Savings active) Recurrence: Always (When in Daylight Savings Time) Severity: Minor Priority: High (for an internet radio station) Domain: http://www.wrrj.org Module: Calendar (report is specifically on the block) Screenshot: http://url.wrrj.org/5 The calendar module is not properly handling Daylight Savings Time as indicated in the screenshot. Currently, I am in Daylight Savings Time. When I am not in Daylight Savings time, the calendar works fine. As you can see in the screenshot, whether or not the calendar module has the correct time is quite random. All events are set to GMT-5 America/New_York and do not have "adjust to member's timezone" enabled. The times that are indicated in a red circle are incorrect (they should be 1 hour earlier). The "Mo" end time circled in red should not be there and should be Sunday. The times marked with a green circle are correct.
Steps To Reproduce	1. Create a calendar event. 2. Set the event to the time zone of GMT-5 (Eastern Time) 3. Create a calendar block on the zone with the type "listing" and days shown equal to 2. 4. Clear cache. The problem still exists.
Additional Information	ALL events are recurring. Morning Shine meditations is Daily. Words From the Heart past broadcast, Tibetan Singing Bowl Meditation, and Atmosphere Nature Meditation are weekly. Words From the Heart Evolution is every 2nd and 4th Sunday. Ahowan Caws is every 4th Sunday. This issue seemed to have existed in 9.0.11 and marked as resolved. However as of 9.0.12, I'm still having this issue, and help would greatly be appreciated.
Tags	No tags attached.
Attach Tags	(Separate by ",")
Attached Files	About Us – WRRJ Radio - Google Chrome_981.jpg (108,037 bytes) About Us – WRRJ Radio - Google Chrome_981.jpg (108,037 bytes)

Time estimation (hours)
Sponsorship open

Date Added	Member	Amount Sponsored

Chris Graham 2014-03-24 11:41 administrator ~2095	Thanks for the report. Investigating.

Chris Graham 2014-03-24 14:44 administrator ~2096	Automated response: DST shifts not detected correctly in the calendar Recurring events with a time component may not compensate for a DST shift. E.g. an event started at 2PM, may shift to 3PM.

Chris Graham 2014-03-24 14:44 administrator ~2097	Fixed in git commit c332626 (https://github.com/chrisgraham/Composr/commit/c332626 - link will become active once code pushed) A hotfix (a TAR of files to upload) have been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/). hotfix-1610, 2014-03-24 2pm.tar (60,928 bytes)

Chris Graham 2014-03-24 14:58 administrator ~2098 Last edited: 2014-03-24 14:58	For reference, there were a couple more issues... The "fast forward" code, designed to let a recurring event calculate itself into a future month window, extrapolating rather than looping through each recurrence, forgot to compensate for DST shift. The DST shift detection had a bug which was using the wrong variable to track the change, missing it, or counting it multiple times, in different cases. Whether the bug caused an issue depended on exactly what kind of recurrence was set up.

PDStig 2014-03-24 16:14 administrator ~2099	Thank you Chris. This is to confirm the hotfix has fixed the issue.