#6274 - Better(?) fix for bug 6246: Login failure after expired session
-
By Jason Verhagen
- Added
- 9 views
| Identifier | #6274 |
|---|---|
| Issue type | Trivial issue (does not break functionality) |
| Title | Better(?) fix for bug 6246: Login failure after expired session |
| Status | Open |
| Tags |
Roadmap: v11 (custom) |
| Handling member | Deleted |
| Version | 11 beta8 |
| Addon | core |
| Description | I also ran into the login failure and traced the issue to an out-of-place 'require' code line in sources\global2.php. In v11 branch, sources\globals2.php, Line 474: require_code('site'); // This powers the site (top level page generation) should above the handle_logins() call. This code: if ((!$MICRO_AJAX_BOOTUP) && (!$MICRO_BOOTUP)) { // Before anything gets outputted require_code('users'); handle_logins(); require_code('site'); // This powers the site (top level page generation) } should be: if ((!$MICRO_AJAX_BOOTUP) && (!$MICRO_BOOTUP)) { // Before anything gets outputted require_code('users'); require_code('site'); // This powers the site (top level page generation) handle_logins(); } |
| Steps to reproduce | |
| Additional information | I confirm I searched the tracker for an existing issue. |
| Related to | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
I need some more info. What is the "login" issue? Are you simply getting logged out? Is an error occurring which then logs you out? Are you still getting an undefined function attach_message error?
The purpose of the warning goes back to legal compliance. Region enforcement is necessary to properly enforce age requirements for joining a site (content region enforcement also exists to hide content by region). But we must know a user's region to do that. Law says we should prioritize what a user specifies as their region over what their IP address reveals about their region, so we do that. But the warning serves as a reminder when their IP address region does not match what is on their profile.