#6217 - Code Book, Part 4: Update standard on json_decode use

  • By
  • Added
  • 5 views
Identifier #6217
Issue type Trivial issue (does not break functionality)
Title Code Book, Part 4: Update standard on json_decode use
Status Open
Tags

Roadmap: Over the horizon (custom)

Handling member Deleted
Addon [All Projects] General
Description We should not suppress errors for json_decode anymore. Instead, bump minimum PHP version for Composr to 7.3, and implement cms_json_decode using the JSON_THROW_ON_ERROR flag and a try / catch block to properly handle JSON errors.
Steps to reproduce

Additional information This is because an error can result in a null return, which can conflict with an actual null JSON data (which also returns null). Additionally, suppression affects debugging negatively.
Funded? No
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated