#5815 - Reduce disk checks for error log
-
By PDStig
- Added
- 1 view
| Identifier | #5815 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Reduce disk checks for error log |
| Status | Open |
| Tags |
Roadmap: Over the horizon (custom) Type: Performance (custom) |
| Handling member | Deleted |
| Addon | core |
| Description | Currently Composr has to do a disk check on every page load to ensure errorlog.php has a return line. This is problematic for performance. Actually ideally we would not host any logs in the webroot, but that goes against our target demographics regarding users and their expertise with server administration. Work in an alternate solution. |
| Steps to reproduce | |
| Additional information | Slight increase in performance due to the elimination of an often-unnecessary disk check on every page load. |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
A possible solution is to make a new _config.php directive defining the filename. By default, it is a randomly-generated crypto-hash upon installation. That way we can use the .log extension with a reasonable amount of confidence that no spider or human will guess what it is and access it.
Then upon this process, we will no-longer need to access the error log on every page load to check for return.
Another potential solution is only to check the error log just before we plan to write to it. The return statement would therefore always be in there when something gets written to the log unless someone physically removes that line (and only until something else gets written).
We don't do that due to the possibility of it PHP creating the log, and somehow injecting PHP code into the error messages PHP itself generates.