#5783 - watermarking is broken
| Identifier | #5783 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | watermarking is broken |
| Status | Completed |
| Tags |
Roadmap: v11 (custom) |
| Handling member | PDStig |
| Version | 11 beta4 |
| Addon | galleries |
| Description | Watermarking simply does nothing even if a watermark is assigned to a gallery and was ticked when adding new images. |
| Steps to reproduce | Only tested with mass-add to gallery so far with watermark added directly on the child gallery (not tested with parent galleries) |
| Additional information | GD installed so I expected this to work. |
| Funded? | No |
| Commits |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".


Comments
Watermarking simply does nothing even if a watermark is assigned to a gallery and was ticked when adding new images.
Actually this was part of a larger fundamental issue. Gallery images were not being run through handle_images_cleanup_pipeline unless bulk imported. Therefore, they were not getting watermarked among other things.
This hotfix fixes the following issues:
* Moves calls for handle_images_cleanup_pipeline into the add_image and edit_image API instead of bulk import via media_wrap.
* Fixes find_gallery_watermarks which did not properly navigate the full gallery tree to get all the available watermarks.
* Changes behaviour of using a File/Media library image in a gallery; Composr will copy the image into uploads/galleries and apply handle_images_cleanup_pipeline to that (using that as the image and not the actual File/Media library one). This is to prevent modifying the original file in the file/media library.
* Removes a duplicate SQL clause in Module_cms_galleries::has_at_least_one_watermark