#5636 - Improper parsing in _qualify_url

  • By
  • Added
  • 20 views
Identifier #5636
Issue type Minor issue (breaks specific functionality)
Title Improper parsing in _qualify_url
Status Closed (rejected)
Tags

Roadmap: v11 (custom)

Handling member Chris Graham
Addon General / Uncategorised
Description In _qualify_url, when $base_is_full_url is true, we may get improper parsing.

For example, if $url is closed.html and $url_base is https://somesite.com (closed_file test), then dirname on line 271 results in _qualify_url to create a malformed url "https://somesite.com/https:/closed.html"
Steps to reproduce

Additional information I unfortunately cannot figure out a fix for this, so deferring to you Chris.

Seems to work fine on my localhost dev environment on PHP 7.4. This is AlmaLinux PHP 8.3.3.
Funded? No
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated