#5568 - Points ledger: set sender_id and recipient_id as nullable
-
By PDStig
- Added
- 12 views
| Identifier | #5568 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | Points ledger: set sender_id and recipient_id as nullable |
| Status | Completed |
| Handling member | PDStig |
| Addon | General / Uncategorised |
| Description | We've run into a complex situation involving #5555 where a member could match recipient_id and therefore not own the record. As such, we can't delete it (the only allowed method).
The fallback is anonymising. But as the points system stands right now, Guest has special meaning (e.g. system credits / debits), so we can't anonymise either. But overall, we can't just do nothing; that violates the GDPR. So since we can't fix this on the privacy end, we must fix this on the points end. If we change the points API such that null is system, the problem is that the fields become nullable and the privacy purge will null instead of setting to guest. So, let's just set sender_id and recipient_id to nullable, but we don't actually use null for any meaning in the points API (actually we do, null will just mean "unknown member" instead of system). Privacy purge will then set these to null on a purge, and the points system will still use Guest for system transfers. We will, however, have to add null checks into the API. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments