#5496 - _backups unit test is broken
-
By PDStig
- Added
- 9 views
| Identifier | #5496 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | _backups unit test is broken |
| Status | Open |
| Tags |
Roadmap: Over the horizon (custom) |
| Handling member | Chris Graham |
| Addon | General / Uncategorised |
| Description | The _backups unit test is broken.
It needs mysql root to create the test database to restore into. When I tried modifying the unit test to put that in the _config.php file (at the end) within the backup exports, this did not work. It still tried to use the other non-root username. I also tried moving this config file temporarily to the main config file when running the restore iterations, thinking it was using the main config file and not the one in the test folder. But I was wrong; it was trying to use the test folder config, so that did not work either. This unit test needs careful re-review. For the time being, it's low priority because admins are encouraged to use their web panel for backups instead. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
Sounds like it is making some unneeded or undocumented assumptions though, which should be corrected.
I changed the semantic meaning of underscores.
No = standard test, can run concurrently
Single = Slower test, can run concurrently but only in single-thread
Double = Slower test / messes with settings or could break other tests. Cannot run concurrently. Should be run sparingly.
Triple = Must be run via command line. Cannot run concurrently. Should be run sparingly.
Tests not expected to pass are indicated as such in comments inside the files.
We now have separate directories... first_tests, cli_tests, async_tests, and sync_tests.
The underscore semantics are as follows:
None = Expected to pass, and should be run on every patch, minor, and major release.
Single underscore = Expected to pass but may need special consideration. Should be run on every minor and major release, but not necessary for patch releases.
Double underscore = Not expected to pass and needs careful review. Should be run on every major release. Not necessary for minor or patch releases.