#5489 - Make release: tar on Windows 11 "option --force-local is not supported"

By PDStig
Added 6th Dec 2023, 11:24 AM
1 view

Identifier	#5489
Issue type	Major issue (breaks an entire feature)
Title	Make release: tar on Windows 11 "option --force-local is not supported"
Status	Open
Handling member	Chris Graham
Addon	General / Uncategorised
Description	Later builds of Windows 10, and Windows 11, come with their own tar which does not support --force-local. This causes make-release to fail. However, we can't just assume everyone building Composr on Windows has the Windows tar which doesn't support --force-local, so we can't remove it. But we also can't assume vice versa, so we can't just leave it in there either. Modify make_release to handle both cases.
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 6th Dec 2023, 12:14 PM

temporary fix via https://gitlab.com/composr-foundation/composr/-/commit/0ab6279a603337319fcc11995679482c22ad87bb

I added a force_local get parameter. Must be specified and = 1 to put --force-local in the tar command on Windows.

By Guest posted 31st Jul 2024, 3:07 PM

I think it's reasonable to assume core developers are running a newer version of Windows. The constituency is now just 1, it's reasonable to have a higher baseline for developers, it's reasonable for us to not even officially document it for core development situations like this that are just dealing with legacy situations. I'd just add a code comment saying "Tested to work on Windows version xxx, known to not run on versions older than yyy due to not having tar bundled."

#5489 - Make release: tar on Windows 11 "option --force-local is not supported"

Rating

Comments

Statistics