#5488 - If something fails to compile (filesize 0), *_enforce should probably try re-compiling it once
| Identifier | #5488 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | If something fails to compile (filesize 0), *_enforce should probably try re-compiling it once |
| Status | Closed (no changes needed) |
| Handling member | Deleted |
| Addon | General / Uncategorised |
| Description | In css_enforce and javascript_enforce, if the "compiled" version of the file in templates_cached is 0 bytes, the function simply returns blank without trying anything. Instead, we should probably attempt to recompile the file once, and if it's still 0 bytes, we return blank at that point. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".


Comments
It shouldn't be possible to accidentally write 0 bytes to a file. I'd have to analyze the code again to ensure that, but barring a real-world condition of there being a problem causing a reevaluation, I think the issue should remain closed.
Fix might be to have a Git post-update hook that calls decache.php.