#5433 - Improve database_relations with hooks

By PDStig
Added 3rd Nov 2023, 11:08 PM
5 views

Identifier	#5433
Issue type	Feature request or suggestion
Title	Improve database_relations with hooks
Status	Open
Tags	Roadmap: Over the horizon (custom)
Handling member	Deleted
Addon	core
Description	Currently, database relations are defined in database_relations.php . However, get_table_purpose_flags, get_table_descriptions, and get_relation_map are usually addon-based. Perhaps migrate these to addon_registry hook functions for relevant addons. Another nice feature we could possibly add is a unit test that checks get_relation_map and ensures that, when mapping to fields of tables in other addons (as defined in get_table_purpose_flags perhaps), the relevant addons are listed under "requires" or "recommends" and is not listed under "conflicts with".
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 24th Jul 2024, 5:52 PM

I agree with most of this except I'd prefer actually addon_registry hooks get smaller, not bigger. Just make a new hook type.

By Guest posted 24th Jul 2024, 6:06 PM

How about we put them in the info functions of the modules instead, since that's where the tables get created anyhow?

By Guest posted 24th Jul 2024, 6:11 PM

It uses considerable memory loading up metadata from a lot of files. We have a hack to pull in individual functions from classes so we don't generally take the hit of parsing all the PHP files at once, but even then we don't want to have information in there that is only needed for obscure stuff like docs generation or testing.

#5433 - Improve database_relations with hooks

Rating

Comments

Statistics