#5379 - Top 10 block code not working

By Adam Edington
Added 25th Mar 2023, 12:09 PM
12 views

Identifier	#5379
Issue type	Trivial issue (does not break functionality)
Title	Top 10 block code not working
Status	Open
Handling member	Chris Graham
Version	10.0.43
Addon	galleries
Description	Top 10 block code in POPULAR.tpl seems to be returning recent content rather than ordering by popularity.
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 12th Nov 2023, 4:19 PM

Is ratings enabled? The block by design uses most recent instead of top 10 when ratings are disabled because without ratings there is no metric for determining "top" galleries.

By Guest posted 14th Nov 2023, 3:09 PM

Reviews were enabled, which include ratings (might not be the same, kinda weird having 2 different methods of rating potentially available). I recall that regardless of the ratings being enabled or not that all blocks show up on root but the Top 10 code was ordering by latest (which as you've explained is likely intentional). You can leave this one be as I've since deleted the install and can't refer to it.

By Guest posted 17th Nov 2023, 11:02 PM

I think I found the issue. The block is using the wrong parameters. I'll push a hotfix as soon as I can.

By Guest posted 19th Nov 2023, 9:20 PM

GALLERY_POPULAR is using the wrong parameter: "mode" when it should be using "sort". However, beyond that, it's still not ordering by rating, and I have no idea why. SQL looks fine to me.

(also "top" is not a valid sorting mechanism... it should be "average_rating")

#5379 - Top 10 block code not working

Rating

Comments

Statistics