#5238 - Social sharing: Need to test Facebook, Tumblr, VK
| Identifier | #5238 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Social sharing: Need to test Facebook, Tumblr, VK |
| Status | Completed |
| Handling member | Chris Graham |
| Addon | General / Uncategorised |
| Description | Facebook, Tumblr, VK require an account to share something and do not offer any previews prior to login as to what the content would look like (thus I cannot verify that sharing works correctly). I do not have accounts on these platforms. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".


Comments
localhost gives no error just times out
live hosting gives the error "Parse error: syntax error, unexpected string content "docs/pages/comcode_cu", expecting "]" in sources_custom/hooks/systems/addon_registry/composr_tutorials.php on line 1577
Also of note, I use peazip and I have errors extracting the v11 tar or zip. Unspecified errors but thought I'd mention it.
EDIT: The issue about missing blocks and modules likely also would have been caused by an incomplete download.
The issue with Peazip is now fixed. There was a symlink in the Git repository, which didn't agree with Windows. I've removed the symlink and added it to our testing for that to not happen again.
As for installation timeouts, I've just done some benchmarking and optimisation but I can see more is required. Step 7 is 13 second son my machine, Step 8 is 20 seconds.
Up and running v11, yay. Yes, Port 80 was added to the base URL by the installer on my live hosting but I noticed and removed it.
Just on the installer again...
I've optimised it to Step 7 as 10 seconds, and Step 8 as 12 seconds. So roughly 1/3 faster.
I'm not too worried about the installer performance from Git given that there is a lot more to install from Git due to all the non-bundled addons being included. But users may use some very slow servers so it was worth taking the chance to make the gains I reasonably could.
There's some code in HTML_HEAD.tpl:
{+START,IF_EMPTY,{$METADATA,image}}
{$SET,fallback_image,{$IMG,logo/standalone_logo}}
<meta property="og:image" content="{$GET*,fallback_image}" />
<meta property="og:image:width" content="{$IMG_WIDTH*,{$GET,fallback_image}}" />
<meta property="og:image:height" content="{$IMG_HEIGHT*,{$GET,fallback_image}}" />
{+END}
It says to use the logo for the Open Graph image if there is no natural image on the page (natural image might be the images associated with the news article being viewed, for example).
The Facebook tutorial contains a section "Vastly simplifying the images", which shows how to make a new custom Open Graph image, should you want better than that. I'm renaming that tutorial "Composr Supplementary: Facebook Support / Open Graph" to indicate it also documents Open Graph (which is Facebook's system that they standardised and is now widely adopted).