#5218 - Previews: mass_select_delete_form and mass_select_marker are blank
-
By PDStig
- Added
- 7 views
| Identifier | #5218 |
|---|---|
| Issue type | Trivial issue (does not break functionality) |
| Title | Previews: mass_select_delete_form and mass_select_marker are blank |
| Status | Completed |
| Handling member | Chris Graham |
| Addon | General / Uncategorised |
| Description | mass_select_delete_form and mass_select_marker previews are blank.
mass_select_delete_form has a display: none. And mass_select_marker has a conditional in the template which is not satisfied (thus does not display) for previews. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
Yes, usually the templates behind mass_select_delete_form/mass_select_marker aren't visible. This is by design (literally, design) to keep them low-key. But other designs may do differently so they do need to be previewable.
That said, viewing these screen previews out of context is pointless. The correct thing is to formally define them as previewed under tpl_preview__block_main_gallery_embed, and then adjusting the _template_previews test to not demand the template actually be used in the preview it says it is used in.
I've done a big reworking and tidy up of how/what we are defining as ones that don't need explicit previews, what is shown as full screen, what is shown as code, etc.