#5050 - Forum adapters: User cookies not being properly created for auto-login into third-party forums
-
By PDStig
- Added
- 2 views
| Identifier | #5050 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | Forum adapters: User cookies not being properly created for auto-login into third-party forums |
| Status | Completed |
| Tags |
Roadmap: v11 (custom) |
| Handling member | Chris Graham |
| Addon | General / Uncategorised |
| Description | The auto-login cookies system needs a major overhaul as it does not work correctly for third-party forum drivers; they seek specific cookie names (without the cms__ prefix) to work. |
| Steps to reproduce | |
| Additional information | MyBB:
MyBB indicates that a cookie, mybbuser, stores the login information for a user. Upon log-in of a user into Composr using the MyBB forum driver, it should create a "mybbuser" cookie. But it is not creating any cookies / the user is not being auto-logged into MyBB. Furthermore, there are additional problems: 1) Composr is using the name "cms__mybbuser" for the cookie when MyBB wants "mybbuser". 2) Since the cookie name trying to be created starts with "cms__", the code in the mybb.php driver responsible for updating the MyBB session token / IP / cookie is not executing. https://docs.mybb.com/1.8/development/cookies/ --- phpBB: Cookies are being created, but they have the CMS prefix on them, which phpBB does not recognize. Also, there should be a phpbb session cookie phpbb_sid (we only have cms_session). https://www.phpbb.com/community/viewtopic.php?t=2428331 |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
Actually we put on a "cms__" prefix on cookies because of a lack of confidence they are going to integrate correctly for the typical user. The user needs to get the cookie domain and path consistent between Composr and the forum, which will be beyond the understanding of many users (not the making consistent necessarily, but choosing a universally-compatible domain and path combination). The user can remove the "cms__" in the installer if they wish.
To avoid confusion the cookie settings in the installer are no longer hidden for third party forum installation and it explicitly explains this.
The phpBB session cookie is created by the Composr phpBB forum driver, but the code was only executing if the "cms__" prefix is not there.