#4932 - Tooltip generation code is a mess
| Identifier | #4932 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Tooltip generation code is a mess |
| Status | Completed |
| Tags |
Roadmap: v11 (custom) |
| Handling member | Chris Graham |
| Addon | core |
| Description | "CROP_TEXT_MOUSE_OVER_*" is a confusing term for a tooltip generator, rename to *_TOOLTIP (as we have other *_TOOLTIP functions already so it combines to form a set)
tpl_crop_text_mouse_over is a confusing name for a function for another reason, as the 'tpl_' prefix is nowadays used for template previews not regular functions; rename to generate_tooltip_by_truncation There are no direct functions for generating the tooltips with set text, add inline_tooltip and block_tooltip - and make generate_tooltip_by_truncation a front-end to them We should not be using INLINE_TOOLTIP/BLOCK_TOOLTIP templates directly now we have a function TEXT_LARGE/TEXT_SMALL parameters should be renamed, it may not even be text and 'small' and 'large' is indirect terminology; use TOOLTIP/LABEL BLOCK_TOOLTIP/block_tooltip used too much, often we may want to use inline_tooltip / Alter generate_tooltip_by_truncation to show the inline tooltips if appropriate Only use generate_tooltip_by_truncationinline_tooltip/block_tooltip if we cannot use the truncate symbols ($TRUNCATE_*) combined with our normal HTML/JavaScript symbol_truncator vs generate_tooltip_by_truncation - rationalise why we have these two different functions generate_tooltip_by_truncation should be able to take Tempcode and/or HTML |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".


Comments
There have been no comments yet