#4928 - Merge notification types
-
By Chris Graham
- Added
- 5 views
| Identifier | #4928 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Merge notification types |
| Status | Completed |
| Tags |
Roadmap: v11 (custom) |
| Handling member | PDStig |
| Addon | core_notifications |
| Description | On a stale cache we are pushing at the limits of our 32MB memory limit generating the edit profile tabs, largely due to our very large number of notification types.
Additionally, having so many notification types is not good usability. Patrick and I have gone through and decided how we can rationalise them. birthday_points -- merge into points_transaction cns_choose_avatar + cns_choose_photo + cns_choose_signature -- merge cns_group_join_request - should not be visible if member is not a group leader (via implementing member_could_potentially_enable function) cns_group_declined + cns_rank_promoted -- merge cns_username_changed+cns_password_changed -- merge, on by default cns_new_pt + cns_topic_invite -- merge ecom_product_request_forwarding + ecom_product_request_pop3 + ecom_product_request_quota -- merge error_occurred* + health_check -- merge, and use categories content_validated + needs_validation -- merge, and use categories service_* + subscription_cancelled_staff -- merge, and use categories staff_checklist + checklist_task + task_completed -- merge Additionally, we need to add a very simple new automated test in _tests/tests/unit_tests/notification_classifications.php (note to Patrick: this is on v11 branch since you forked your current dev branch for this issue, you need to merge) that ensures there are no more than 70 notification hooks under sources/hooks/systems/notifications. This will stop us letting them creep up again. Additionally, on running notification_classifications you will see many hook files need to be merged to make testNoPointlessNotificationHookSeparation pass. Do that, the test should pass. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments