#4739 - Some basic locking for addon management

Identifier #4739
Issue type Feature request or suggestion
Title Some basic locking for addon management
Status Completed
Handling member Chris Graham
Version 10.0.39
Addon core_addon_management
Description Users often have errors caused by parallel web requests happening while addons are being uninstalled.
For example, they may click an addon uninstallation button and then refresh their browser window so it happens twice in parallel, or while running the Setup Wizard also be browsing the Admin Zone in another tab.
These things can cause errors as caches decached by the addon removal can get repopulated with stale data from an overlapping request.

This changes introduces some locking. It's not perfect. There's a maximum lock time of 1 minute to prevent stale lock problems disabling user's sites. It also won't protect the case of another web request starting before the lock and then populating the cache after the addon management web request finishes. That last scenario is less likely though as an addon management web request would be expected to be a much longer running request.
Steps to reproduce

Funded? No
Commits

Fixed MANTIS-4739 (Some basic locking for addon management) (e310af6d) · Commits · Composr ecosystem / Composr · GitLab

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated